Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change or add Villagebox villager trades #20

Open
jawsawn opened this issue Jan 17, 2017 · 9 comments
Open

Cannot change or add Villagebox villager trades #20

jawsawn opened this issue Jan 17, 2017 · 9 comments

Comments

@jawsawn
Copy link

jawsawn commented Jan 17, 2017

I think I'm supposed to do that? Why can't I do that?

@jawsawn
Copy link
Author

jawsawn commented Jan 17, 2017

The config keeps reseting itself, i think it doesn't work as a configurable config.

@ckhgame
Copy link
Owner

ckhgame commented Jan 18, 2017

I tested again just in case and it's working, I tried twice but both time the existed VillageBoxData.json didn't be replaced with the default one.

The code doesn't allow it to happen as well

public static void LoadData(File dir)
{
	File file = new File(dir, jsonDataFileName);
	if(file.exists())
	{
		try {
			loadDataFromFile(file);
		} catch (IOException e) {
			e.printStackTrace();
		}
	}
	else
	{
		try {
			createDefaultDataFile(file);
		} catch (IOException e) {
			e.printStackTrace();
		}
	}		
}

@ckhgame
Copy link
Owner

ckhgame commented Jan 18, 2017

Do you have other mods installed? I guess maybe something cleans up the config folder every time MC launches

@jawsawn
Copy link
Author

jawsawn commented Jan 18, 2017

I have FTBU and I do /reload and /reload_client commands.

Also have Crafttweaker if it matters, using the Skyexchange 2 Lite pack,

I just love this mod, it even fits with projecte in a skyblock pack.

@ckhgame
Copy link
Owner

ckhgame commented Jan 19, 2017

Thank you! I'm so glad you love our mod :D
I don't see these matter..
Did you change the VillageBoxData.json on both client and server?
VillageBoxData.json currently is not syncing across server and client(will be added in next version)..so you have to change the file on one side, and then manually copy it to another.

@jawsawn
Copy link
Author

jawsawn commented Jan 19, 2017

I also tried it clientside only. But how do I make sure the changes apply? Restart the client or does /reload works from ftbu?

@jawsawn
Copy link
Author

jawsawn commented Jan 19, 2017

And I have tried with only jei and villagebox, I changed the current values and added a different trade.

And when i closed the client and re opened it nothing changed, looked at the configs file and the things i have changed has reset to original values, but the lines I've added still remain. But no effect to the game.

@ckhgame
Copy link
Owner

ckhgame commented Jan 19, 2017

you mean the json file remains changed but it doesn't affect the game? It sounds like the game is loading a different file rather than the one you modified. Do you have more than one minecraft installed on the same machine?

@jawsawn
Copy link
Author

jawsawn commented Jan 19, 2017

Of course I do, I use curse with many profiles if its the thing you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants