Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon toolbar overflows outside the editor #17814

Open
kubaklatt opened this issue Jan 24, 2025 · 6 comments
Open

Balloon toolbar overflows outside the editor #17814

kubaklatt opened this issue Jan 24, 2025 · 6 comments
Labels
package:ui support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@kubaklatt
Copy link

kubaklatt commented Jan 24, 2025

📝 Provide detailed reproduction steps (if any)

  1. Open the prepared sample to reproduce the issue: issue.zip

(This is a classic editor sample generated from the builder with a balloon toolbar, only the editor height has been changed and a header has been added)

  1. Bring up the balloon toolbar and scroll the content down

✔️ Expected result

The balloon toolbar remains within the boundaries of the editor and does not overflow outside of it.

❌ Actual result

The balloon toolbar extends beyond the boundaries of the editor and overflows outside of it.

overflowing.mov

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@kubaklatt kubaklatt added package:ui type:bug This issue reports a buggy (incorrect) behavior. labels Jan 24, 2025
@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Jan 24, 2025
@Witoso
Copy link
Member

Witoso commented Jan 27, 2025

Please always add screenshots to the issues. Thanks to that, we will be able to quickly asses if it's an issue related to some other or a duplicate.

@kubaklatt
Copy link
Author

Sorry, I don't know why I didn't add a screencast. Done already 👌🏼

@Witoso
Copy link
Member

Witoso commented Jan 27, 2025

May be related: #17009, #14662

But #14662, mentions it shouldn't happen for balloons anymore (but maybe it meant feature's toolbars). Could you check the behavior of a feature toolbar? Is this a regression?

@kubaklatt
Copy link
Author

If you mean the balloon editor, from what I see the toolbar can also float outside the editor (I don't know if it matters, but for me it was more reproducible and noticeable at slower scrolling).

Screen.Recording.2025-01-28.at.13.22.14.mov

It also looks like a problem from that former PR - #14755

@Witoso
Copy link
Member

Witoso commented Jan 28, 2025

All screencasts show balloon toolbar, PR related to features' balloon toolbar. @pszczesniak I assume there's a difference. There's also ui.viewportOffset option but this is for fixed elements near the editor.

@pszczesniak
Copy link
Contributor

Yes, it needs a deeper investigation.

For "simple" balloon it works ok - i've tested it here (i've added height to the editing view div). When i want to add a link on a selected word and scroll it outside editor - it disappeared, like it should.

In some cases it's not working with toolbars balloons.

But image and table toolbars works ok (tested on full-feature example with editor height set to 300px).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants