Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the results of blockchain.*.unpack is inconsistent with api.* #600

Closed
homura opened this issue Jan 5, 2024 · 0 comments · Fixed by #601
Closed

Some of the results of blockchain.*.unpack is inconsistent with api.* #600

homura opened this issue Jan 5, 2024 · 0 comments · Fixed by #601

Comments

@homura
Copy link
Collaborator

homura commented Jan 5, 2024

          Thanks for your PR. However, I have noticed that the `blockchain.Transaction.unpack` function behaves differently from `api.Transaction`. The `blockchain` module directly uses number codecs, which results in the unpacked output being either a `number` or a `BI`. Ideally, any type of number should be in `string(hex formatted)`. This inconsistency was not caused by your PR, but by your comment "cannot set number 0 to call pack", which drew my attention to it. To address this issue, Lumos may have to modify the `blockchain.*.unpack` function to output a `string(hex format)` instead of a `number`.

Originally posted by @homura in #599 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant