Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to hide menu items Organizations and Groups not working #134

Open
brooks-eco opened this issue Sep 8, 2024 · 1 comment · May be fixed by #137
Open

Options to hide menu items Organizations and Groups not working #134

brooks-eco opened this issue Sep 8, 2024 · 1 comment · May be fixed by #137

Comments

@brooks-eco
Copy link

tested CKAN 2.11

options to hide menu items not working as expected

ckanext.pages.group_menu = False
ckanext.pages.organization_menu = False

menu items remain

The option to remove "About" ckanext.pages.about_menu = False does work

I do not understand all the code and have not traced further but there may be some logic inverted in the code -

https://github.com/ckan/ckanext-pages/blob/master/ckanext/pages/plugin.py

image

Editing to below and rebooting did not work assume more to it:

        if arg[0] in 'home.group_index' and not group_menu:
            continue
        if arg[0] in 'home.organizations_index' and not org_menu:
            continue

menu items for organizations and groups remain visible... I'm not skilled to fix sorry

@brooks-eco brooks-eco changed the title Options not working Options to hide menu items Organizations and Groups not working Sep 8, 2024
@brooks-eco
Copy link
Author

brooks-eco commented Sep 28, 2024

PR to fix this here #137

@brooks-eco brooks-eco linked a pull request Sep 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant