Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you update to d3 version 4? #11

Open
paulocoutinhox opened this issue Jul 28, 2017 · 8 comments
Open

Can you update to d3 version 4? #11

paulocoutinhox opened this issue Jul 28, 2017 · 8 comments

Comments

@paulocoutinhox
Copy link

Hi,

Can you update to d3 version 4?

Thanks.

@one2gov
Copy link

one2gov commented Aug 21, 2017

@guanw
Copy link

guanw commented Oct 9, 2017

Hi, @one2gov Trying to do upgrading in my own project found some issue with the dragging behavior. D3 V4 prevents "circle mouse up" to fire as default when you drag a line from one circle to another. Do you have any good suggestion to get info of circle in V4 that was recognized in circle mouse up event in V3 implementation?

@guanw
Copy link

guanw commented Oct 10, 2017

@one2gov Actually I was able to fix this by looping through all nodes to find the one that's connected in "end" callback. Now I have a similar issue with edges like your stack overflow question:
https://stackoverflow.com/questions/45801254/migrating-to-d3-v4-cause-duplicates-on-drag. When I started to drag it renders lots of paths during dragging. Now I have to check how to make this disappeared..

@guanw
Copy link

guanw commented Oct 10, 2017

@one2gov looks like path.enter() will get fired even when I'm dragging the big circle here. I changed .data() for path a little bit and it magically makes infinite paths disappeared.

@one2gov
Copy link

one2gov commented Oct 11, 2017

@guanw thx for sharing! I am really stuck with this one) I'll try to finish my attempt on stackoverflow.

@ghamarian
Copy link

@guanw and @one2gov did you guys manage to port this?

@ghamarian
Copy link

I ported this library to d3, version 5.7. You can find it here:
https://github.com/ghamarian/graph_editor

@faso
Copy link

faso commented Feb 19, 2019

For anyone still looking for a solution, I've posted mine here (as an answer)

https://stackoverflow.com/questions/45801254/migrating-to-d3-v4-cause-duplicates-on-drag/54773054#54773054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants