From 61cffcb80cc6196fddcdbe4bf4712ac35c73aebe Mon Sep 17 00:00:00 2001 From: Drew Miller <49833875+wwdrew@users.noreply.github.com> Date: Fri, 12 Aug 2022 12:30:08 +0100 Subject: [PATCH 1/4] feat: upgrade Android Auth library to 2.0.1 --- android/build.gradle | 2 +- android/external/SpotifySDK | 2 +- .../main/java/com/reactlibrary/RNSpotifyRemoteAuthModule.java | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index d46cd21..ea8c0b7 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -67,7 +67,7 @@ repositories { } dependencies { - implementation (files("external/SpotifySDK/auth-lib/spotify-auth-release-1.2.3.aar")) + implementation (files("external/SpotifySDK/auth-lib/spotify-auth-release-2.0.1.aar")) implementation (files("external/SpotifySDK/app-remote-lib/spotify-app-remote-release-0.7.2.aar")) implementation "com.google.code.gson:gson:2.8.5" // needed by spotify-app-remote //noinspection GradleDynamicVersion diff --git a/android/external/SpotifySDK b/android/external/SpotifySDK index cfd6b68..66b95f5 160000 --- a/android/external/SpotifySDK +++ b/android/external/SpotifySDK @@ -1 +1 @@ -Subproject commit cfd6b68a47440a7db8afac1983d92d324a1c0015 +Subproject commit 66b95f5c16d9d74d0ec711c105c52361e471c796 diff --git a/android/src/main/java/com/reactlibrary/RNSpotifyRemoteAuthModule.java b/android/src/main/java/com/reactlibrary/RNSpotifyRemoteAuthModule.java index 6668798..6a6ebe4 100644 --- a/android/src/main/java/com/reactlibrary/RNSpotifyRemoteAuthModule.java +++ b/android/src/main/java/com/reactlibrary/RNSpotifyRemoteAuthModule.java @@ -120,8 +120,6 @@ public void endSession(Promise promise) { mConnectionParamsBuilder = null; mConfig = null; - AuthorizationClient.clearCookies(this.getReactApplicationContext()); - RNSpotifyRemoteAppModule remoteModule = reactContext.getNativeModule(RNSpotifyRemoteAppModule.class); if (remoteModule != null) { remoteModule.disconnect(promise); From 04da71a8afda85cd0b8f6ecd16b90402a111776b Mon Sep 17 00:00:00 2001 From: Drew Miller <49833875+wwdrew@users.noreply.github.com> Date: Fri, 12 Aug 2022 13:13:07 +0100 Subject: [PATCH 2/4] docs: update changelog and add to contributors --- .all-contributorsrc | 9 +++++++++ CHANGELOG.md | 4 ++++ README.md | 36 ++++++++++++++++++------------------ 3 files changed, 31 insertions(+), 18 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index d0c7fd6..e16909a 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -147,6 +147,15 @@ "contributions": [ "code" ] + }, + { + "login": "wwdrew", + "name": "Drew Miller", + "avatar_url": "https://avatars.githubusercontent.com/u/49833875?v=4", + "profile": "https://github.com/wwdrew", + "contributions": [ + "maintenance" + ] } ], "contributorsPerLine": 7 diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bdefc6..b055bde 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Update + +- Upgrade Android Auth library to 2.0.1 + ### Gradle Change - Updated gradle to import sdks using sourceSets diff --git a/README.md b/README.md index f0cf21f..b6c16df 100644 --- a/README.md +++ b/README.md @@ -261,7 +261,7 @@ Please do not open issues about getting the module to work unless you have tried Big thanks to [@lufinkey](https://github.com/lufinkey) and all of the great work that he has done in the [react-native-spotify](https://github.com/lufinkey/react-native-spotify) repo which was the original source of inspiration and some useful patterns for this package. -[![All Contributors](https://img.shields.io/badge/all_contributors-15-orange.svg?style=flat-square)](#contributors-) +[![All Contributors](https://img.shields.io/badge/all_contributors-16-orange.svg?style=flat-square)](#contributors-) @@ -269,31 +269,31 @@ Big thanks to [@lufinkey](https://github.com/lufinkey) and all of the great work - - - - - - - + + + + + + + - - - - - - - + + + + + + + - + +

Colter McQuay
💻
Luis Finke
🤔
Stanislav
💻
Will Caine
💻
Everaldo Rosa de Souza Junior
💻
İbrahim Can KALYA
💻
Mahmoud Ashraf Mahmoud
💻
Colter McQuay
💻
Luis Finke
🤔
Stanislav
💻
Will Caine
💻
Everaldo Rosa de Souza Junior
💻
İbrahim Can KALYA
💻
Mahmoud Ashraf Mahmoud
💻

Şerafettin Aytekin
💻
Peter Stenger
💻
Reinhard Höll
🐛 💻
Gustavo Graña
🐛 💻
Dylan
💻
Hoang
💻
Hendri Pretorius
🐛 💻
Şerafettin Aytekin
💻
Peter Stenger
💻
Reinhard Höll
🐛 💻
Gustavo Graña
🐛 💻
Dylan
💻
Hoang
💻
Hendri Pretorius
🐛 💻

suryababus
💻
suryababus
💻
Drew Miller
🚧
- + - ## Projects using this library From 3fcfc8e4a23aa5fbdd234b0ce3118301a0acbde7 Mon Sep 17 00:00:00 2001 From: Drew Miller <49833875+wwdrew@users.noreply.github.com> Date: Thu, 18 Aug 2022 20:04:04 +0100 Subject: [PATCH 3/4] add browser dependency for upgraded Spotify SDK and bump version for gson --- android/build.gradle | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index ea8c0b7..f2290c9 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -69,7 +69,9 @@ repositories { dependencies { implementation (files("external/SpotifySDK/auth-lib/spotify-auth-release-2.0.1.aar")) implementation (files("external/SpotifySDK/app-remote-lib/spotify-app-remote-release-0.7.2.aar")) - implementation "com.google.code.gson:gson:2.8.5" // needed by spotify-app-remote + implementation "com.google.code.gson:gson:2.8.9" // needed by spotify-app-remote + implementation "androidx.browser:browser:1.4.0" + //noinspection GradleDynamicVersion implementation "com.facebook.react:react-native:+" // From node_modules } From f1b03faa990952d8ec99e143ab5d2e2a7ce01124 Mon Sep 17 00:00:00 2001 From: Drew Miller <49833875+wwdrew@users.noreply.github.com> Date: Mon, 22 Aug 2022 17:17:04 +0100 Subject: [PATCH 4/4] update auth-sdk to 2.0.2 --- CHANGELOG.md | 2 +- android/build.gradle | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b055bde..ea65b20 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Update -- Upgrade Android Auth library to 2.0.1 +- Upgrade Android Auth library to 2.0.2 ### Gradle Change diff --git a/android/build.gradle b/android/build.gradle index f2290c9..2374099 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -67,7 +67,7 @@ repositories { } dependencies { - implementation (files("external/SpotifySDK/auth-lib/spotify-auth-release-2.0.1.aar")) + implementation "com.spotify.android:auth:2.0.2" implementation (files("external/SpotifySDK/app-remote-lib/spotify-app-remote-release-0.7.2.aar")) implementation "com.google.code.gson:gson:2.8.9" // needed by spotify-app-remote implementation "androidx.browser:browser:1.4.0"