Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Surface could be a class instead of dict? #85

Open
balazsdukai opened this issue Jun 10, 2021 · 0 comments
Open

Semantic Surface could be a class instead of dict? #85

balazsdukai opened this issue Jun 10, 2021 · 0 comments
Labels
API enhancement New feature or request

Comments

@balazsdukai
Copy link
Member

Currently its a bit confusing that there is a Geometry class with its methods and such, but the Semantic Surfaces are just plain dict-s. Thus when getting the boundaries of the sem surf-s, we need to use the Geometry methods, and need to know that we are accessing dictionaries. Not very intuitive.

groundsrf = geom.get_surfaces(type='groundsurface')
ground_boundaries = [geom.get_surface_boundaries(g) for g in groundsrf.values()]

I think I would prefer sth like below. Although, it would add quite a bit of overhead for keeping all those semantic objects, esp. in triangulated models.

groundsrf = geom.get_surfaces(type='groundsurface')
ground_boundaries = [srf.boundary for srf in groundsrf]
@balazsdukai balazsdukai added enhancement New feature or request API labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant