Move CI images to GHCR #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
older versions of docker could only run bigger blocks by writing them as a oneliner for bash. Since newer versions you can use the following syntax RUN <<'EOF' ... EOF Which makes the blocks easier to read and maintain, given that they don't have to have a trailing \ on every line. Only where we write single statements that would span multiple lines we need the trailing \, eg. with long lists of packages to install.
…nt installation of older packages We already pinned a lot of the postgres packages this way, except we missed the postgresl-$PG_MAJOR pacakges. This has caused unexpected image build failures.
… construct to succeed
thanodnl
force-pushed
the
fix/image-builds
branch
from
b9f5f67
to
5c0f4e6
Compare
hanefi
reviewed
Jul 11, 2024
hanefi
approved these changes
Jul 11, 2024
Co-authored-by: Hanefi Onaldi <[email protected]>
thanodnl
force-pushed
the
fix/image-builds
branch
from
9d76d56
to
661ed2f
Compare
hanefi
pushed a commit
to citusdata/citus
that referenced
this pull request
Jul 12, 2024
We move the CI images to the github container registry. Given we mostly (if not solely) run these containers on github actions infra it makes sense to have them hosted closer to where they are needed. Image changes: citusdata/the-process#157
hanefi
pushed a commit
to citusdata/citus
that referenced
this pull request
Jul 17, 2024
We move the CI images to the github container registry. Given we mostly (if not solely) run these containers on github actions infra it makes sense to have them hosted closer to where they are needed. Image changes: citusdata/the-process#157 (cherry picked from commit e776a7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation of this patch is to move the images to the github container registry. But as quite often the case, the images were not building, thus some changes needed to be made to get the images to build.
postgresql-$PG_MAJORversion to the same pgdg version. For pg16.2 new packages have been created. This happens once in a while and to counter that we already pin most of the postgres ecosystem packages to a specific pgdg version. Somehowpostgresql-...wasn't part of the pinning, causing some errors during image builds.The scripts used the old syntax of multi line run blocks, requiring a lot of escaping and chaining of lines with the trailing
\character. Newer versions of docker allow an easier to maintain and readable syntax viaGiven I already needed to change the body of many of the RUN blocks I took the liberty to refactor this at the same time. This is all captured in the first commit (barring I squash the fixups, let me know if I forgot :P). For review it might be easiest to review the commits separately.