Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider storing tools version in env #948

Open
hanefi opened this issue Jul 28, 2022 · 2 comments
Open

Consider storing tools version in env #948

hanefi opened this issue Jul 28, 2022 · 2 comments
Assignees
@gurkanindibay

Comments

@hanefi
Copy link
Member

hanefi commented Jul 28, 2022

We have many workflows that want to use the latest version of tools repository. This means that we change many workflow definitions on seemingly irrelevant PRs such as #945

I suggest we come up with a way to share the common tools version that is used in all the workflows in a single place. A possible solution is to create an env file. See https://arinco.com.au/blog/github-actions-share-environment-variables-across-workflows/
@hanefi hanefi mentioned this issue Apr 26, 2023
Merged
@gurkanindibay
Copy link
Contributor

It is not correct to set all the pipelines equal. In this case, we don't need to version. We can use the latest version in this case.

@gurkanindibay
Copy link
Contributor

I'm updating when it is needed after I execute tests one by one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gurkanindibay gurkanindibay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gurkanindibay @hanefi