Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RedHat TopN to 2.4.0 #760

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Bump RedHat TopN to 2.4.0 #760

merged 4 commits into from
Sep 14, 2021

Conversation

hanefi
Copy link
Member

@hanefi hanefi commented Sep 14, 2021

No description provided.

@gurkanindibay
Copy link
Contributor

gurkanindibay commented Sep 14, 2021

I see some problematic warnings. It's better to fix them
warning: bogus date in %changelog: Thu Dec 21 2018 - Furkan Sahin [email protected] 2.2.2.citus-1
topn_11.x86_64: E: zero-length /usr/pgsql-11/share/extension/topn--2.2.2--2.3.0.sql
error: Package check "/usr/bin/rpmlint -f /rpmlintrc /citus-rpm-build/x86_64/topn_14-2.4.0.citus-1.el7.x86_64.rpm" failed.
These are nor super urgent since some of them are very old but I think an issue can be opened

@hanefi
Copy link
Member Author

hanefi commented Sep 14, 2021

I see some problematic warnings. It's better to fix them
warning: bogus date in %changelog: Thu Dec 21 2018 - Furkan Sahin [email protected] 2.2.2.citus-1
topn_11.x86_64: E: zero-length /usr/pgsql-11/share/extension/topn--2.2.2--2.3.0.sql
error: Package check "/usr/bin/rpmlint -f /rpmlintrc /citus-rpm-build/x86_64/topn_14-2.4.0.citus-1.el7.x86_64.rpm" failed.
These are nor super urgent since some of them are very old but I think an issue can be opened

I created an issue and added one more warning message in there as well.

I think we can go ahead and move forward, as these 2 warnings you shared should actually be fixed in the project repo, not here.

Copy link
Contributor

@gurkanindibay gurkanindibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after issue. Please link issue to this PR

Copy link
Contributor

@gurkanindibay gurkanindibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after issue. Please link issue to be able to track the reason we open issue

@hanefi hanefi linked an issue Sep 14, 2021 that may be closed by this pull request
@hanefi hanefi merged commit cf20e57 into redhat-topn Sep 14, 2021
@hanefi hanefi deleted the redhat-topn-2.4.0 branch September 14, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TopN RedHat warnings
3 participants