Invalid PAD_DIGITALBUTTON binds somehow bind to A/LB in vehicle

[blattersturm]

A bind such as bind pad_digitalbutton up "say Now this is racing!" (which is an invalid index for PAD_DIGITALBUTTON, see the docs) somehow still creates a bind which triggers when pressing A (lower face button) in a vehicle.

When reproducing this, it should be noted that I had 'swap RB/A in vehicle' enabled in gamepad config, if this is needed.

Might be a mixup of different enums containing UP, even.

[gottfriedleibniz]

Might be a mixup of different enums containing UP, even.

This seems to be the case. Looking at GetParameterIndex, there is clearly some bit flag action not being referenced or sanitized. IOMS_PAD_DIGITALBUTTON, for instance, does the mapping return i | 0x20000u.

Referencing rage__ioMapperParameter, the pad buttons start at 0x20000u:

L2 = 0x20000,
R2 = 0x20001,
L1 = 0x20002,
...
LUP = 0x2000c,
...
LLEFT = 0x2000f,
TOUCH = 0x20010,

In my case, KEY_UP = 0x26 will map to RDOWN = 0x20006 which seems consistent with UngetParameterIndex's path for IOMS_PAD_DIGITALBUTTON overflowing.

[gottfriedleibniz]

Another note to self:

fivem/code/components/gta-core-five/src/GameInput.cpp

Lines 848 to 855 in 68751bf

	if (!xbr::IsGameBuildOrGreater<2060>())
	{
	button->SetFromControl((char*)g_control + 0x21A98, field->index); // 1604
	}
	else
	{
	button->SetFromControl((char*)g_control + 0x21B78, field->index); // 2198
	}

Should be patternized.