Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create revue-suisse-dhistoire.csl #7186

Merged
merged 11 commits into from
Sep 11, 2024

Conversation

POBrien333
Copy link
Contributor

Copy link

github-actions bot commented Sep 2, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/revue-suisse-dhistoire.csl (rendering failure)
dependent/rivista-storica-svizzera.csl (rendering failure)

@adam3smith
Copy link
Member

No, please put the ISSN back in as per my comment on the issue

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

Copy link

github-actions bot commented Sep 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

@adam3smith
Copy link
Member

adam3smith commented Sep 2, 2024 via email

@POBrien333
Copy link
Contributor Author

Hi Sebastian,
Would you be able to merge this in the coming days?
Then I can get this off my todo list and also inform this former client it's now up.
Much appreciate your efforts! 🙏🏽

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 10, 2024
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/revue-suisse-dhistoire.csl (rendering failure)
dependent/rivista-storica-svizzera.csl (rendering failure)

@bwiernik bwiernik merged commit 016de07 into citation-style-language:master Sep 11, 2024
1 check passed
@bwiernik
Copy link
Member

Merged it!

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 11, 2024
@POBrien333
Copy link
Contributor Author

Excellent!! Thank you so much both for helping with this. :)

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to handle journal with name in 3 languages?
3 participants