-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create revue-suisse-dhistoire.csl #7186
Create revue-suisse-dhistoire.csl #7186
Conversation
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: dependent/revue-suisse-dhistoire.csl (rendering failure)dependent/rivista-storica-svizzera.csl (rendering failure) |
No, please put the ISSN back in as per my comment on the issue |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
😟 There are some issues with your submission. 1 test failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs
Please check the test report for details. |
Might be that the CI doesn't look at the updated ISSN list. I'll double
check and merge, don't worry about the failure
…Sent from my phone
On Mon, Sep 2, 2024, 15:54 github-actions[bot] ***@***.***> wrote:
😟 There are some issues with your submission.
1 test failed
*The CSL Style Repository may not contain any (non-excepted) duplicate
ISSNs*
expected: {}
got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}
(compared using ==)
Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],
Please check the test report
<https://github.com/citation-style-language/styles/actions/runs/10672391101>
for details.
—
Reply to this email directly, view it on GitHub
<#7186 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7PWSSLKMLOLMKZD2BG4DZUS7AJAVCNFSM6AAAAABNQNTZHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGI2TANZQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hi Sebastian, |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: dependent/revue-suisse-dhistoire.csl (rendering failure)dependent/rivista-storica-svizzera.csl (rendering failure) |
Merged it! |
Excellent!! Thank you so much both for helping with this. :) |
Closes #7184 (comment)