-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split LangCheck into language-specific packages such as langcheck[ja]
, langcheck[de]
, etc
#88
Comments
hello, kenny, I may have time add a small update for this but I have few questions
the github action file may also need a small update like, pip install -e .[dev,zh,ja], e.g. what's your opinion ? |
Hi @Vela-zz, that would be fantastic!
I think we can make
Agreed, we'll need to update all GH Actions, including the new Pip Install Matrix (we might want to add a third matrix dimension for "language").
@liwii do you know which dependencies in pyproject.toml are Japanese-only? @ischender do you know which dependencies in pyproject.toml are German-only? (if any?) I'm happy to help you with parts of this PR, e.g. I can update GitHub Actions, if you want. |
Also, not sure if this is possible, but it might be nice to have |
That would be neat! |
Since some language-specific packages (e.g.
fugashi
for Japanese) may require extra work to install, we can simplify the installation instructions for users by allowing them to choose only the languages they want to install.The text was updated successfully, but these errors were encountered: