Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy check for SharePoint 3.2 when using service principal and update SharePoint 4.2 rego for deprecation #1309

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add policy check for SharePoint 3.2 when using service principal and update SharePoint 4.2 rego for deprecation #1309

wants to merge 15 commits into from

Commits on Sep 24, 2024

  1. remove PnpFlag flag which was set to false

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5ee77be View commit details
    Browse the repository at this point in the history

  2. remove PnP flag from SharepointConfig.rego and unit tests

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    03b7afc View commit details
    Browse the repository at this point in the history

  3. modified unit tests for service principal case for sharepoint 3.2

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0a902ec View commit details
    Browse the repository at this point in the history

  4. build out sharepoint pnp fnc tests

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fca454b View commit details
    Browse the repository at this point in the history

  5. add additional unit tests to cover incorrect file/folder settings wit… 

    …h service principal
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    42b8d69 View commit details
    Browse the repository at this point in the history

  6. fix opa unit test lint complaint

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    86a0481 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary fields from spo fnc tests to remove warnings

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2604000 View commit details
    Browse the repository at this point in the history

  8. removed deprecated parameter from Get-SPOSite/Get-PnPTenantSite

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    68e443c View commit details
    Browse the repository at this point in the history

  9. cleanup

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e9f04e9 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    beaa65c View commit details
    Browse the repository at this point in the history

  11. address feedback on unit test settings; set PnP flag to true in servi… 

    …ce principal tests
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    130e52c View commit details
    Browse the repository at this point in the history

  12. address logic flaw in policy 3.1 which didnt consider negative intege… 

    …r values
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f1e9c6c View commit details
    Browse the repository at this point in the history

  13. update policies 3.1-3.3 NA cases to match baseline terminology; updat… 

    …ed unit tests
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bda739c View commit details
    Browse the repository at this point in the history

  14. change sharepoint policy 4.2 to not implemented, update unit/function… 

    …al tests
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    32bd22a View commit details
    Browse the repository at this point in the history

  15. add additional test case to account for anyone link value of 0 (unche… 

    …cked), added to both unit/functional tests
    @mitchelbaker-cisa
    mitchelbaker-cisa committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8f181fb View commit details
    Browse the repository at this point in the history