Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if additional functional or unit tests are needed for Entra Id provider Get-PrivilegedUser #1340

Open
6 tasks
tkol2022 opened this issue Sep 26, 2024 · 1 comment
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function
Milestone

Comments

@tkol2022
Copy link
Collaborator

💡 Summary

The Entra Id provider script has incorporated some complex logic over time and in order to continuously test the scenarios that were coded, we need an automated repeatable mechanism. In particular the Get-PrivilegedUser function and the recursive LoadObjectDataIntoPrivilegedUserHashtable function. For the most recent PR #1310 I had to concoct and document some multi-step scenarios for manual testing by PR reviewers. Those take careful setup in the tenant and an eye for detail on the part of the reviewer, plus they require manual labor.

The scope of this issue is to examine the code, determine which test scenarios need long-term automated test cases, and then determine how to codify those tests which will require some creative solutions given the constraints involved with manipulating the tenant to set up the objects needed. We also have some automated unit tests that exercise the

Implementation notes

  • Examine the logic for the LoadObjectDataIntoPrivilegedUserHashtable and Get-PrivilegedUser functions. Document the distinct scenarios that are codified in a spreadsheet.
  • Examine the existing unit tests in LoadObjectDataIntoPrivilegedUserHashtable.Tests.ps1 and document the scenarios being tested and the scope of the tests. If there are any gaps, note them.
  • Determine which new functional tests are needed.
  • Determine which new unit tests are needed.
  • Since the existing functional test orchestrator does not have an existing mechanism to conduct tests of this complexity within the tenant, determine if the orchestrator needs to be augmented.
  • Create new issues to codify the updates
@tkol2022 tkol2022 added enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function labels Sep 26, 2024
@tkol2022 tkol2022 added this to the Kraken milestone Sep 26, 2024
@tkol2022
Copy link
Collaborator Author

@nanda-katikaneni @mitchelbaker-cisa See if you want to team up on this since you recently tested some related scenarios.

@schrolla schrolla changed the title determine if additional functional or unit tests are needed for Entra Id provider Get-PrivilegedUser Determine if additional functional or unit tests are needed for Entra Id provider Get-PrivilegedUser Oct 30, 2024
@schrolla schrolla modified the milestones: Kraken, Backlog Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality Testing This issue or task involves testing the automation tool function
Projects
None yet
Development

No branches or pull requests

2 participants