From 9def86d0a0d0ff3fcd6f189abc633f457d33bd92 Mon Sep 17 00:00:00 2001 From: fkorotkov Date: Tue, 22 Sep 2020 10:59:17 -0400 Subject: [PATCH] Show image pull progress in a separate Echelon node --- internal/executor/instance/instance.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/executor/instance/instance.go b/internal/executor/instance/instance.go index 131b027d..caf213b3 100644 --- a/internal/executor/instance/instance.go +++ b/internal/executor/instance/instance.go @@ -122,12 +122,16 @@ func RunDockerizedAgent(ctx context.Context, config *RunConfig, params *Params) } if config.DockerOptions.ShouldPullImage(params.Image) { - logger.Debugf("pulling image %s", params.Image) + dockerPullLogger := logger.Scoped("docker pull") + dockerPullLogger.Infof("Pulling image %s...", params.Image) progress, err := cli.ImagePull(ctx, params.Image, types.ImagePullOptions{}) if err != nil { + dockerPullLogger.Errorf("Failed to pull %s: %v", params.Image, err) + dockerPullLogger.Finish(false) return err } _, err = io.Copy(ioutil.Discard, progress) + dockerPullLogger.Finish(err == nil) if err != nil { return err }