Should stop stream from camera after once capture?

[mkotsbak]

After capturing a QR code once, the camera stream to the video element is continuing. I would expect it to stop.

To ensure that this functionality breaks #32, there should probably be a boolean parameter to say if the stream should be left running.

[mkotsbak]

I implemented this in the Scala.Js wrapper: https://github.com/mkotsbak/scalajs-qcode-decoder/blob/master/src/main/scala/io/github/mkotsbak/qcodeDecoder/QCodeDecoder.scala#L47

[cirocosta]

Hi @mkotsbak ! Thanks for pointing that!

I'll take a look soon (today) and then we decide how to proceed on that 👍 I'm also willing to change some configs regarding zuul, which is annoyingly saying that your PR is not passing 😞

By the way, i didn't know about scala-js! What are you developing on top of it?

[mkotsbak]

Okay, the solution I added to the wrapper should be easy to do in this library as well.

Scala.js is really nice (hard to typesafe this library that sends so many types of objects as errors...). I'm working on some software to recognize the name badges of participants on a conference, running on a Raspberry Pi.

[cirocosta]

wow, sounds pretty cool! Just a reminder: feel free to contribute with pull requests! i'd appreciate a lot!

[stccorp]

I just want to comment that the idea that keeps scanning is perfect for me. So every project is different.