Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: person tracking #53

Open
skuro opened this issue Sep 27, 2021 · 1 comment · May be fixed by #54
Open

Feature request: person tracking #53

skuro opened this issue Sep 27, 2021 · 1 comment · May be fixed by #54

Comments

@skuro
Copy link
Contributor

skuro commented Sep 27, 2021

In order to use the person tracking Rollbar feature, a person key is sent along with the payload. There's currently a TODO on it in the codebase on the subject.
@skuro
Copy link
Contributor Author

skuro commented Sep 27, 2021

My proposal is to add an optional argument to make-rollbar so that it can actually propagate the person data. I'll try to come up with a rough PR to explain my concept a bit better, but something along the lines of

(defn notify
  "Report an exception to Rollbar."
  ([^String level client ^Throwable exception]
   (notify level client exception {}))
  ([^String level {:keys [result-fn send-fn block-fields] :as client} ^Throwable exception {:keys [url params person]}] ;; <-- here!
   ..same as before..))

skuro added a commit to skuro/rollcage that referenced this issue Sep 27, 2021
@skuro
Allow person data to be sent through the API
bf911de 
Fixes circleci#53 by allowing a `:person` map to be passed through the API
call, without breaking any existing API contract
@skuro skuro linked a pull request Sep 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow person data to be sent through the API skuro/rollcage
1 participant
@skuro