Allow clj-v8 to be bundled in an uberjar #7
Conversation
- clj-v8 fails in an uberjar, since it relies on its files to be accessible on the file system. - this is because JNI and JNA relies on the native binaries to be on the file system. - so in order to be bundled in an uberjar, we have to copy the files out to a temporary location when loading the native library.
- clj-v8 fails in an uberjar, since it relies on its files to be accessible on the file system. - this is because JNI and JNA relies on the native binaries to be on the file system. - so in order to be bundled in an uberjar, we have to copy the files out to a temporary location when loading the native library. See CircleCI-Archived/clj-v8#7
|
Responding in CircleCI-Archived/stefon#9 to keep discussion in the same place. |
|
We've been using this in production (in uberjars on Ubuntu), and on development machines, both OSX and Linux, for a few days. Just as a heads up. :-) |
|
Still working nicely. Have you tried running the tests? |
|
This has now been tested further on some 32 bit linux machines as well. Had to add some archetypes to the native binary lookup. But now that works too. |
|
What's up with the lack of response? I see it's been a year since any development has been done. When I said in #clojure on freenode that I was using clj-v8, someone said "Isn't that project dead?" ... Is it? |
|
Sorry for the lack of response. I've been ultra busy for the last few weeks, but there wasnt anyone at Circle who knew clj-v8 (or stefon) deeply enough to pick it up. The project isn't dead at all. It's feature complete for the stefon use-case, and no-one has requested/contributed other use cases (and I don't have any other ones). RE this PR, I think it's valuable, just needed the time to look more closely at it. |
|
Hi Paul, Thanks for the response. I know the stress of being swamped with work. I'm Hope you get some time off for the holidays, and hope to hear from you
On Sun, Dec 22, 2013 at 11:02 PM, Paul Biggar [email protected]:
|
Allow clj-v8 to be bundled in an uberjar
|
Apologies for the delay, this looks good. |
|
Thanks for the merge! How do you do releases? |
|
If you want to make a PR with the updates for the release, I can do the push to clojars. |
|
I can do that. But do you mean there's something else to do than bump the version? I see that clj-v8-native is on version 0.1.4, but clj-v8 doesn't use it - it's still on 0.1.3. Any thoughts on that? |
|
Adding a changelog to the README, and updating the version numbers were what I was thinking. |
|
0.1.4 or 0.1.3 for native? |
|
0.1.4 |
accessible on the file system.
file system.
to a temporary location when loading the native library.
The entire investigation can be read for your amusement or horror in CircleCI-Archived/stefon#9.
I have not been able to run your tests - since that too results in a UnsatisfiedLinkError (see #6), but I have packaged this version in our uberjar, and that works.