Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-profile test isn't on by default #13

Open
AlexanderMann opened this issue Jun 22, 2017 · 4 comments
Open

with-profile test isn't on by default #13

AlexanderMann opened this issue Jun 22, 2017 · 4 comments

Comments

@AlexanderMann
Copy link

Motivation

I got thrown for a loop when with-profile test wasn't being used by default.

https://circleci.com/gh/circleci/service-utils/48

Suggested Musical Pairing

https://www.youtube.com/watch?v=W3q8Od5qJio

@technomancy
Copy link
Member

The docs for Leiningen now specifically advise against using the test profile, but it wouldn't hurt to add a line or two explaining the gotcha in the readme here.

@leblowl
Copy link

leblowl commented Jun 4, 2018

@technomancy are you referring to this statement:

Please note that putting things in the :test profile is strongly advised against as it can result in tests which can't be run from the repl.

?

I can see the benefit for having more portable tests. Do you have any ideas on how to handle test specific configuration? That's what I was thinking of using the test profile for. Any thoughts? Thanks

brainstorm attempt 1:

  • use a global fixture to change my project's resource-paths temporarily or inject a new test specific configuration state if using component or mount.

@technomancy
Copy link
Member

@leblowl right... I think there are ways to do this that are reasonable and don't involve Leiningen profiles.

I don't think it's a good idea to have a separate config for tests vs repl stuff, but if you really decide you want it then you can find a way to make it work with fixtures or some other mechanism. Describing how this would work is out of scope though, because it heavily depends upon how your application is configured.

@leblowl
Copy link

leblowl commented Jun 4, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants