Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt before sending invalid commands #1919

Closed

Conversation

cloudrac3r
Copy link
Contributor

Description

This was previously a feature I added in #1435, but it got lost in a refactor. Here it is again.

When a message starts with / but didn't trigger a command, the popup will be shown. The popup allows sending it anyway, or going back to edit.

To make this work, I made the submit function async, which does not seem to have had any negative consequences.

This feature will prevent mistakes like this:

image

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

Preview: https://1919--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura
Copy link
Member

ajbura commented Jan 10, 2025

as we now have wysiwyg editor command, emojis, mentions are only appear when they are picked explicitly or selected with the tab press, everything is suppose to work as appear into the editor. so it is not a good idea to add invalid command dialog because even when the command exist with specific prefixed plaintext it wont run unless it appear as cmd pill

@ajbura ajbura closed this Jan 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants