Add prompt before sending invalid commands #1919
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was previously a feature I added in #1435, but it got lost in a refactor. Here it is again.
When a message starts with
/
but didn't trigger a command, the popup will be shown. The popup allows sending it anyway, or going back to edit.To make this work, I made the submit function async, which does not seem to have had any negative consequences.
This feature will prevent mistakes like this:
Type of change
Checklist: