Skip to content
This repository has been archived by the owner on Apr 13, 2019. It is now read-only.

Execute Bot#configure in the Callback instance #85

Open
dominikh opened this issue May 23, 2012 · 3 comments
Open

Execute Bot#configure in the Callback instance #85

dominikh opened this issue May 23, 2012 · 3 comments
Milestone
Version 3.0.0

Comments

@dominikh
Copy link
Member

We used to do this and not doing it breaks instance variable initialization for on handlers.
@causal-agent
Copy link
Contributor

👍

Workarounds for now?

@dominikh
Copy link
Member Author

dominikh commented Jul 2, 2012

Use the plugin architecture instead of plain on handlers. The latter were always supposed for very basic things, not necessarily things that have state.

@dominikh
Copy link
Member Author

This cannot be fixed before Cinch 3.0, because changing it breaks backwards compatibility.

@dominikh dominikh added this to the Version 3.0.0 milestone Mar 17, 2014
dominikh added a commit that referenced this issue Mar 17, 2014
@dominikh
Fix basic examples that depend on state
f646988 
Due to gh-85, it's not possible to set instance variables in the
configure block. Replace those uses of instance variables that need
initialization with global variables.

For the autovoice plugin, simply recognize that its initial state is
"off".

Closes gh-84
Closes gh-110
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3.0.0
Development

No branches or pull requests
2 participants
@dominikh @causal-agent