Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of params in link method is unintuitive #115

Open
jtnelson opened this issue Nov 29, 2015 · 0 comments
Open

Order of params in link method is unintuitive #115

jtnelson opened this issue Nov 29, 2015 · 0 comments
Assignees
@javierlores

Comments

@jtnelson
Copy link
Member

The add, set and remove methods have a signature with order key, value, record
The link and unlink methods have a signature with order key, source, destination

it would probably be more intuitive to have the link signature be key, destination, source
jtnelson added a commit that referenced this issue Jun 15, 2016
@jtnelson
Merge pull request #175 from javierlores/feature/GH-115
2d9a7d7 
GH-115: Changed the parameter order for 'link' and 'unlink' method
javierlores added a commit that referenced this issue Jun 16, 2016
@javierlores
CON-470: Update param order in driver docs as per GH-115
9f0d678 
Updated the documentation blocks in the Ruby, PHP, and Python drivers to match the parameter order for the link and unlink methods in the Concourse class of the Java driver. Related to GH-115
@javierlores javierlores mentioned this issue Jun 16, 2016
Merged
jtnelson added a commit that referenced this issue Jun 16, 2016
@jtnelson
Merge pull request #177 from cinchapi/feature/CON-470
2f7508d 
CON-470: Update param order in driver docs as per GH-115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierlores javierlores

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtnelson @javierlores