Fix incorrect variables n backtest.NewReport
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables passed to `backtest.NewReport` are for repository configuration settings causing the script to fail. This correctly sets `reportName` and `reportConfig`.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 92.69% 92.83% +0.14%
==========================================
Files 163 163
Lines 4161 4161
==========================================
+ Hits 3857 3863 +6
+ Misses 247 243 -4
+ Partials 57 55 -2 ☔ View full report in Codecov by Sentry. |
|
Wow! This definitely went out of sync. Thank you very much for catching and fixing it. Greatly appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variables passed to
backtest.NewReportare for repositoryconfiguration settings causing the script to fail.
This correctly sets
reportNameandreportConfig.