Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COmanage QDL scripts #45

Open
jjg-123 opened this issue Mar 27, 2024 · 0 comments
Open

Update COmanage QDL scripts #45

jjg-123 opened this issue Mar 27, 2024 · 0 comments

Comments

@jjg-123
Copy link
Contributor

jjg-123 commented Mar 27, 2024

There are QDL scripts for COmanage that use the has_keys function. This function is deprecated now since it is really just a pain in the neck to use. Only COmanage uses it, nears as can be told. Moreover, several of the scripts could be rewritten to be a lot less verbose. For instance, on DEV in /var/local/cilogon_service/oa4mp-server/qdl/COmanageRegistry/default/ldap_claims.qdl from line 43 forward, the entire script should be equivalent to

claims. := claims. ~ get_claims(ldap_claim_source., claims.sub);
rename_keys(claims., config_params.ldap_to_claim_mappings, true);

A more minimal change, however is to replace line 74:

has_keys(claims., [i]).0;
with

has_key(i, claims.);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant