build: Rename 'check' and 'fix' targets

Now that we have new targets 'tidy' and 'tidy-fix', rename the old
clang-format targets 'check' and 'fix' as 'format' and 'format-fix',
respectively.

Signed-off-by: Jarno Rajahalme <[email protected]>

Author: jrajahalme

Dockerfile

@@ -100,7 +100,7 @@ ENV TARGETARCH=$TARGETARCH
 #
 # Check format
 #
-RUN BAZEL_BUILD_OPTS="${BAZEL_BUILD_OPTS}" PKG_BUILD=1 V=$V DEBUG=$DEBUG make V=1 check > format-output.txt
+RUN BAZEL_BUILD_OPTS="${BAZEL_BUILD_OPTS}" PKG_BUILD=1 V=$V DEBUG=$DEBUG make V=1 format > format-output.txt
 
 FROM scratch AS format
 COPY --from=check-format /cilium/proxy/format-output.txt /

Makefile.dev

@@ -66,10 +66,10 @@ tidy-fix: compile_commands.json force-non-root
 	echo "clang-tidy fix results can contain duplicate includes, check before committing!"
 	run-clang-tidy-17 -fix -format -style=file -quiet -extra-arg="-Wno-unknown-pragmas" -checks=misc-include-cleaner -j $(TIDY_JOBS) $(TIDY_SOURCES)
 
-check: force-non-root
+format: force-non-root
 	$(BAZEL) $(BAZEL_OPTS) run $(BAZEL_BUILD_OPTS) @envoy//tools/code_format:check_format -- --path "$(PWD)" --skip_envoy_build_rule_check --add-excluded-prefixes $(FORMAT_EXCLUDED_PREFIXES) --bazel_tools_check_excluded_paths="./" --build_fixer_check_excluded_paths="./" check || echo "Format check failed, run 'make fix' locally to fix formatting errors."
 
-fix: force-non-root
+format-fix: force-non-root
 	$(BAZEL) $(BAZEL_OPTS) run $(BAZEL_BUILD_OPTS) @envoy//tools/code_format:check_format -- --path "$(PWD)" --skip_envoy_build_rule_check --add-excluded-prefixes $(FORMAT_EXCLUDED_PREFIXES) --bazel_tools_check_excluded_paths="." --build_fixer_check_excluded_paths="./" fix
 
 # Run tests without debug by default.