[Linux] cider-linux-x86.desktop file Icon=cider-linux-x64

[ChrisLauinger77]

Preflight Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.
• I have checked that the correct behavior occurs on Apple Music Web (if applicable).
• I have verified that my issue is with a supported version and that it is with the desktop app (Support for other areas can be found in our Discord / on the appropriate repo).

How did you download Cider?

itch.io

Operating System

Debian testing

Commit Hash

10f889bf4ed729588d6089e0e8d6bda53e0fbcf0

Build Timestamp

1736389840425

Describe the Bug

Icon=cider-linux-x64
On linux there are tons of icon themes which ship either a cider.png or a cider.svg
I use morewaita for example.
It would not show an icon with the provided desktop file ciders-linux-x86.desktop because of the Icon entry.
So I made a custom .desktop file and changed to
Icon=cider
I tested with multiple themes I have installed and all showed an icon.
So my point is - I guess you should ship an icon named
/usr/share/pixmaps/cider.png
instead of
/usr/share/pixmaps/cider-linux-x64.png
and also reflect this change in the desktop file.
It would benefit the freedom in linux (I guess).

Steps to Reproduce

install cider in linux but use a different icon theme.
There is a high possiblilty that no app icon is shown.

Anything else?

No response

[coredev-uk]

I was not aware that that other icon themes accommodated for Cider. I will amend the filename.

[coredev-uk]

Please try the latest experimental release from Taproom. Let me know if this fixes your issue.

[ChrisLauinger77]

The new desktop file has a bug.
I needed to change one line
"Exec=cider %U" -
in the provided one the it is
"Exec=Cider %U" -
effect is the new desktop file is never shown.

I had also an update issue:
I just took the provided deb from taproom. And the package name changed.
So after installing this one I had 2 cider packages installed:
cider-linux-x86 - installdir /usr/lib/cider-linux-x86
cider - installdir /usr/lib/cider (but no desktop file shown because of the bug)

So I started cider over the old desktop file and wondered why everything is like it was no fixes there.
So i purged both packages.
Then only installed the new one.
Fixed the desktop file - now I am happy :D - the icon from my cus theme is shown :D

[ChrisLauinger77]

I have one more improvement for the desktop file:
I saw in the provided one in experminental Play-Pause etc actions are provided which is nice.
But only for unity :(

I changed them:

Actions=PlayPause;Next;Previous;Stop

[Desktop Action PlayPause]
Name=Play-Pause
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.PlayPause

[Desktop Action Next]
Name=Next
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Next

[Desktop Action Previous]
Name=Previous
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Previous

[Desktop Action Stop]
Name=Stop
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Stop

Those ones are for DBUS and supposed to work in any desktop
zipped desktop file with all improvements:
cider.zip

If you do not like the Stop - just delete it - it was not in the original

[ChrisLauinger77]

For the renaming of the package it could be solved in the control file:

Declare it as replacing and conflicting with the other package in the debian control file
https://www.debian.org/doc/debian-policy/ch-relationships.html#replacing-whole-packages-forcing-their-removal

[coredev-uk]

The package name was updated, yes, unfortunately the recommendations you are making regaridng the control spec, I cannot apply due to the way we package, this is a limitation of the packager. As for the issue you mentioned regarding the executable defined in the desktop file, I cannot see how this is being set, it should be Cider always (I did want it to follow lower-case syntax since the majority of linux apps do this, but for macOS it is required and it doesnt let me set it conditionally).

I have applied the recommendations you said about for the desktop actions. But this is the best I can do.

Just to clarify, the binary name is now cider in the deb?

[ChrisLauinger77]

then people need to made aware to uninstall the old package and install the new ...

This is in the "old" package

As you can see - Exec all non capital
In the new package it is Cider (capital C)
new package:

but the symlinc in /usr/bin is not capital

it can be fixed by the fixing the symlink to Capital or the desktop file to non-capital I guess, but probably non capital in desktop file is the way to go

[ChrisLauinger77]

I also learned that the desktop file can be localized:

Actions=PlayPause;Next;Previous;Stop

[Desktop Action PlayPause]
Name=Play-Pause
Name[de]=Abspielen-Pausieren
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.PlayPause

[Desktop Action Next]
Name=Next
Name[de]=Nächstes
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Next

[Desktop Action Previous]
Name=Previous
Name[de]=Vorheriges
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Previous

[Desktop Action Stop]
Name=Stop
Name[de]=Stop
Exec=dbus-send --print-reply --dest=org.mpris.MediaPlayer2.cider /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Stop
``

[coredev-uk]

Localisation will be tricky considering its a closed-source project. I am the only one working on Linux platform releases and doing localisation myself will be a lot of work which I do not have the time for. I'll add the ones you have provided here, but I cannot do much more. As for your previous remarks, making people aware is not that easy, as far as I know the Cider users on Linux are a minority and reaching out to only them is not possible. If people know their systems, they will know if they have additional packages, just as you have identified. As for the binary, I think I have found the source of the name being wrong.

[ChrisLauinger77]

Well the binary is installed to /usr/lib/cider/Cider
But this is usually not in the path of any linux distro.
Therefor the package makes a smylink to /usr/bin/cider
And the name of the file of the /usr/bin symlink has to be used as Exec in desktop file when no path is specified.
Alternatively you could put the absolue filepath as Exec=/usr/lib/cider/Cider

[ChrisLauinger77]

I saw the package here updated as well: https://cidercollective.itch.io/cider/download
But the same bug in desktop file:

The symlinc in /usr/bin/ is non capital - so in the desktop file it also needs to be non capital.
The binary in /usr/lib/cider/ is then capital

The non capital symblink points to the capital executeable.
In the desktop file the name from /usr/bin needs to be used as this is in the path

I use now the version from offical. deb package again - and changed the desktop file after installation.
The rest of the fixes seem to be in (except the actions)