From f5ba32eaa1e10b3d53e491c1069c13796d55329d Mon Sep 17 00:00:00 2001 From: ducharmemp Date: Sun, 27 Jun 2021 11:33:20 -0400 Subject: [PATCH] Updating parent element to be destination element --- addon/components/basic-dropdown-content.ts | 6 +----- addon/templates/components/basic-dropdown-content.hbs | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/addon/components/basic-dropdown-content.ts b/addon/components/basic-dropdown-content.ts index b864e837..a85e045a 100644 --- a/addon/components/basic-dropdown-content.ts +++ b/addon/components/basic-dropdown-content.ts @@ -126,11 +126,7 @@ export default class BasicDropdownContent extends Component { animateOut(dropdownElement: Element): void { if (!this.animationEnabled) return; this.animationClass = this.transitioningInClass; - let parentElement = dropdownElement.parentElement; - if (parentElement === null) return; - if (this.args.renderInPlace) { - parentElement = parentElement.parentElement - } + let parentElement = this.destinationElement; if (parentElement === null) return; let clone = dropdownElement.cloneNode(true) as Element; clone.id = `${clone.id}--clone`; diff --git a/addon/templates/components/basic-dropdown-content.hbs b/addon/templates/components/basic-dropdown-content.hbs index 92bf9c1c..bad45810 100644 --- a/addon/templates/components/basic-dropdown-content.hbs +++ b/addon/templates/components/basic-dropdown-content.hbs @@ -1,6 +1,6 @@ {{! template-lint-disable no-inline-styles }} {{#if @dropdown.isOpen}} -
+
{{#maybe-in-element this.destinationElement @renderInPlace}} {{#if @overlay}}