Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layout] Allow centered slides #28

Open
ciampo opened this issue Dec 19, 2017 · 4 comments
Open

[layout] Allow centered slides #28

ciampo opened this issue Dec 19, 2017 · 4 comments
Assignees
Labels

Comments

@ciampo
Copy link
Owner

ciampo commented Dec 19, 2017

The selected slide would be in the middle of the view.
This would require a few changes to how the carousel works.

@ciampo ciampo added the feature label Dec 19, 2017
@ciampo ciampo added this to the 1.0.0 (MVP) milestone Dec 19, 2017
@ciampo ciampo self-assigned this Dec 19, 2017
@ciampo ciampo modified the milestones: 1.0.0 (MVP), 1.1.0 Jan 21, 2018
@equinusocio
Copy link

equinusocio commented Sep 22, 2018

Can the new CSS scroll snap control may helps?

@ciampo
Copy link
Owner Author

ciampo commented Sep 24, 2018

It could, but it may also require deep refactoring. Also, the new version of the spec is not supported by many browsers, so it would require a fallback solution

@equinusocio
Copy link

equinusocio commented Apr 8, 2019

Btw this can be done easily by composing in the light dom. Users can define slider with a single centered content. Something like this:

<style>
div {
  display: flex; /* or grid */
  justify-content: center;
}
</style>
<macro-carousel>
  <div> [Centered Content] </div>
  <div> [Centered Content] [Centered Content] </div>
  <div> [Centered Content] </div>
</macro-carousel>

@ciampo
Copy link
Owner Author

ciampo commented Apr 22, 2019

By "centered slides" I meant something like this (hope it helps explaining the idea):

Screenshot 2019-04-22 at 1 42 10 PM

@ciampo ciampo removed this from the Backlog milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants