From d3db2ecc4118d27f2156a73da60a56e48ffcdbe8 Mon Sep 17 00:00:00 2001
From: DelaunayAlex <138011689+DelaunayAlex@users.noreply.github.com>
Date: Thu, 7 Nov 2024 15:06:29 +0100
Subject: [PATCH] fix(jira): Check test plan only when the campaign is linked
 with jira issue (#218)

---
 .../jira/infra/HttpJiraXrayImpl.java          |  3 +++
 .../jira/infra/HttpJiraXrayImplTest.java      | 22 +++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/chutney/jira/src/main/java/com/chutneytesting/jira/infra/HttpJiraXrayImpl.java b/chutney/jira/src/main/java/com/chutneytesting/jira/infra/HttpJiraXrayImpl.java
index e49261e5c..15808f6b1 100644
--- a/chutney/jira/src/main/java/com/chutneytesting/jira/infra/HttpJiraXrayImpl.java
+++ b/chutney/jira/src/main/java/com/chutneytesting/jira/infra/HttpJiraXrayImpl.java
@@ -171,6 +171,9 @@ public String createTestExecution(String testPlanId) {
 
     @Override
     public boolean isTestPlan(String issueId) {
+        if (issueId.isEmpty()) {
+            return false;
+        }
         return getIssue(issueId).getIssueType().getId().equals(getIssueTypeByName("Test Plan").getId());
     }
 
diff --git a/chutney/jira/src/test/java/com/chutneytesting/jira/infra/HttpJiraXrayImplTest.java b/chutney/jira/src/test/java/com/chutneytesting/jira/infra/HttpJiraXrayImplTest.java
index 2ae04cde5..0456f5d32 100644
--- a/chutney/jira/src/test/java/com/chutneytesting/jira/infra/HttpJiraXrayImplTest.java
+++ b/chutney/jira/src/test/java/com/chutneytesting/jira/infra/HttpJiraXrayImplTest.java
@@ -90,6 +90,28 @@ void test_issue_as_test_plan() {
                 .hasMessage("Unable to get issue [PRJ-666] : ")
                 .hasRootCauseExactlyInstanceOf(UnknownHostException.class);
         }
+
+        @Test
+        void test_empty_issue_as_test_plan() {
+            // Given
+            String issueId = "";
+
+            var config = new JiraServerConfiguration(
+                "http://fake-server-jira",
+                "user",
+                "password",
+                null,
+                "",
+                ""
+            );
+            var sut = new HttpJiraXrayImpl(config);
+
+            // When
+            boolean result = sut.isTestPlan(issueId);
+
+            // Then
+            assertThat(result).isFalse();
+        }
     }
 
     @Nested