handle t & v feedback

Author: dominikzogg

README.md

@@ -167,7 +167,7 @@ echo $model->getName();
 ### Policy
 
 * [AndPolicy][27]
-* [CallbackPolicyIncludingPath][28]
+* [CallbackPolicy][28]
 * [GroupPolicy][29]
 * [NotPolicy][30]
 * [NullPolicy][31]
@@ -235,7 +235,7 @@ Dominik Zogg 2020
 [26]: doc/Mapping/LazyDenormalizationObjectMapping.md
 
 [27]: doc/Policy/AndPolicy.md
-[28]: doc/Policy/CallbackPolicyIncludingPath.md
+[28]: doc/Policy/CallbackPolicy.md
 [29]: doc/Policy/GroupPolicy.md
 [30]: doc/Policy/NotPolicy.md
 [31]: doc/Policy/NullPolicy.md

doc/Mapping/AdvancedDenormalizationObjectMapping.md

@@ -16,6 +16,7 @@ use Chubbyphp\Deserialization\DeserializerRuntimeException;
 use Chubbyphp\Deserialization\Mapping\DenormalizationFieldMappingBuilder;
 use Chubbyphp\Deserialization\Mapping\DenormalizationFieldMappingInterface;
 use Chubbyphp\Deserialization\Mapping\DenormalizationObjectMappingInterface;
+use Chubbyphp\Deserialization\Policy\GroupPolicy;
 use MyProject\Model\AbstractManyModel;
 use MyProject\Model\Model;
 
@@ -55,7 +56,9 @@ final class ModelMapping implements DenormalizationObjectMappingInterface
     public function getDenormalizationFieldMappings(string $path, string $type = null): array
     {
         return [
-            DenormalizationFieldMappingBuilder::create('name')->getMapping(),
+            DenormalizationFieldMappingBuilder::create('name')
+                ->setPolicy(new GroupPolicy(['baseInformation']))
+                ->getMapping(),
             DenormalizationFieldMappingBuilder::createEmbedOne('one', OneModel::class)->getMapping(),
             DenormalizationFieldMappingBuilder::createEmbedMany('manies', AbstractManyModel::class)->getMapping(),
         ];

doc/Policy/AndPolicy.md

@@ -19,6 +19,6 @@ $policy = new AndPolicy([
     new AnotherPolicy(),
 ]);
 
-echo $policy->isCompliantIncludingPath('path', $model, $context);
+echo $policy->isCompliant('path', $model, $context);
 // 1
 ```

doc/Policy/CallbackPolicy.md

@@ -0,0 +1,21 @@
+# CallbackPolicy
+
+```php
+<?php
+
+use Chubbyphp\Deserialization\Denormalizer\DenormalizerContextInterface;
+use Chubbyphp\Deserialization\Policy\CallbackPolicy;
+use MyProject\Model\Model;
+
+$model = new Model();
+
+/** @var DenormalizerContextInterface $context */
+$context = ...;
+
+$policy = new CallbackPolicy(function (string $path, object $object, DenormalizerContextInterface $context) {
+    return true;
+});
+
+echo $policy->isCompliant('path', $model, $context);
+// 1
+```

doc/Policy/CallbackPolicyIncludingPath.md

@@ -15,6 +15,6 @@ $context = $context->withAttribute('groups', ['group1']);
 
 $policy = new GroupPolicy(['group1']);
 
-echo $policy->isCompliantIncludingPath('path', $model, $context);
+echo $policy->isCompliant('path', $model, $context);
 // 1
 ```

doc/Policy/GroupPolicy.md

@@ -15,6 +15,6 @@ $context = ...;
 
 $policy = new NotPolicy(new SomePolicy());
 
-echo $policy->isCompliantIncludingPath('path', $model, $context);
+echo $policy->isCompliant('path', $model, $context);
 // 1
 ```

doc/Policy/NotPolicy.md

@@ -14,6 +14,6 @@ $context = ...;
 
 $policy = new NullPolicy();
 
-echo $policy->isCompliantIncludingPath('path', $model, $context);
+echo $policy->isCompliant('path', $model, $context);
 // 1
 ```

doc/Policy/NullPolicy.md

@@ -19,6 +19,6 @@ $policy = new OrPolicy([
     new AnotherPolicy(),
 ]);
 
-echo $policy->isCompliantIncludingPath('path', $model, $context);
+echo $policy->isCompliant('path', $model, $context);
 // 1
 ```

doc/Policy/OrPolicy.md

@@ -184,7 +184,7 @@ private function isCompliant(
         DenormalizerContextInterface $context,
         DenormalizationFieldMappingInterface $mapping
     ): bool {
-        return $mapping->getPolicy()->isCompliantIncludingPath($path, $object, $context);
+        return $mapping->getPolicy()->isCompliant($path, $object, $context);
     }
 
     private function getSubPathByName(string $path, string $name): string

src/Container/DecoderFactory.php

@@ -21,10 +21,10 @@ public function __construct(array $policies)
         $this->policies = $policies;
     }
 
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
         foreach ($this->policies as $policy) {
-            if (!$policy->isCompliantIncludingPath($path, $object, $context)) {
+            if (!$policy->isCompliant($path, $object, $context)) {
                 return false;
             }
         }

src/Container/DenormalizerFactory.php

@@ -6,7 +6,7 @@
 
 use Chubbyphp\Deserialization\Denormalizer\DenormalizerContextInterface;
 
-final class CallbackPolicyIncludingPath implements PolicyInterface
+final class CallbackPolicy implements PolicyInterface
 {
     /**
      * @var callable
@@ -18,7 +18,7 @@ public function __construct(callable $callback)
         $this->callback = $callback;
     }
 
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
         return ($this->callback)($path, $object, $context);
     }

src/Container/DenormalizerObjectMappingRegistryFactory.php

@@ -25,7 +25,7 @@ public function __construct(array $groups = [self::GROUP_DEFAULT])
         $this->groups = $groups;
     }
 
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
         if ([] === $this->groups) {
             return true;

src/Container/DeserializerFactory.php

@@ -18,8 +18,8 @@ public function __construct(PolicyInterface $policy)
         $this->policy = $policy;
     }
 
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
-        return !$this->policy->isCompliantIncludingPath($path, $object, $context);
+        return !$this->policy->isCompliant($path, $object, $context);
     }
 }

src/Denormalizer/Denormalizer.php

@@ -8,7 +8,7 @@
 
 final class NullPolicy implements PolicyInterface
 {
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
         return true;
     }

src/Policy/AndPolicy.php

@@ -21,10 +21,10 @@ public function __construct(array $policies)
         $this->policies = $policies;
     }
 
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool
     {
         foreach ($this->policies as $policy) {
-            if ($policy->isCompliantIncludingPath($path, $object, $context)) {
+            if ($policy->isCompliant($path, $object, $context)) {
                 return true;
             }
         }

src/Policy/CallbackPolicyIncludingPath.php src/Policy/CallbackPolicy.php

@@ -8,5 +8,5 @@
 
 interface PolicyInterface
 {
-    public function isCompliantIncludingPath(string $path, object $object, DenormalizerContextInterface $context): bool;
+    public function isCompliant(string $path, object $object, DenormalizerContextInterface $context): bool;
 }