Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return distinct error codes for 'redirects.too_many' depending on whether the starting URL is HTTP/HTTPS #82

Open
april opened this issue Jun 23, 2016 · 2 comments

Comments

@april
Copy link

april commented Jun 23, 2016

The Object looks like this:

{
  "errors": [
    {
      "code": "internal.domain.name.cannot_compute_etld1",
      "summary": "Internal Error",
      "message": "Could not compute eTLD+1."
    },
    {
      "code": "response.no_header",
      "summary": "No HSTS header",
      "message": "Response error: No HSTS header is present on the response."
    },
    {
      "code": "redirects.too_many",
      "summary": "Too many redirects",
      "message": "There are more than 3 redirects starting from `http://blogspot.com`."
    },
    {
      "code": "redirects.http.first_redirect.insecure",
      "summary": "HTTP does not redirect to HTTPS",
      "message": "`http://blogspot.com` (HTTP) redirects to `http://www.blogger.com/`. The first redirect from `http://blogspot.com` should be to a secure page on the same host (`https://blogspot.com`)."
    },
    {
      "code": "redirects.too_many",
      "summary": "Too many redirects",
      "message": "There are more than 3 redirects starting from `https://blogspot.com`."
    }
  ],
  "warnings": []
}
@lgarron
Copy link
Collaborator

lgarron commented Jun 23, 2016

@this is intentional; one is starting from HTTP, the other is starting from HTTPS.
If HTTP redirects to HTTPS on the same host, then having two errors is usually redundant, but there are cases where it's useful to have both.

Would you prefer if they were different error codes, at least?

@april
Copy link
Author

april commented Jun 23, 2016

Oh, you're right. I didn't see that they were from different URLs. Different error codes would be nice, although I guess I could always coalesce errors on my end.

@lgarron lgarron changed the title blogspot.com returns error code 'redirects.too_many' twice Return distinct error codes for 'redirects.too_many' depending on whether the starting URL is HTTP/HTTPS Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants