Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detection of pnpm-lock.yaml files for TurboSnap #785

Open
Niznikr opened this issue Jul 10, 2023 · 3 comments
Open

Support detection of pnpm-lock.yaml files for TurboSnap #785

Niznikr opened this issue Jul 10, 2023 · 3 comments
Labels
needs triage Tracking: Issue needs confirmation

Comments

@Niznikr
Copy link

Niznikr commented Jul 10, 2023

Feature request

TurboSnap currently detects and evaluates yarn and npm lockfiles to avoid re-testing everything if possible. This should also be supported for projects using pnpm.

Proposed solution

Update this bit of code and related tests to ensure pnpm-lock.yaml are supported.

@Niznikr Niznikr added the needs triage Tracking: Issue needs confirmation label Jul 10, 2023
@vladsovetov
Copy link

I believe also should be changed here

On real prod repos where pnpm is used this affects a lot the expenses unfortunately and would be great to solve it ASAP. Meantime I think we will try to generate a yarn/npm lock file to avoid full execution of the snapshots

@lapa182
Copy link

lapa182 commented Nov 9, 2023

Since Next.js is heavily using pnpm in the examples, I wonder when the pnpm-lock file will be included on TurboSnap?

@kevinlandsberg
Copy link

Please fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests

4 participants