Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action buildUrl output is undefined when skipping rebuild #784

Closed
samtjo opened this issue Jul 10, 2023 · 4 comments
Closed

Github Action buildUrl output is undefined when skipping rebuild #784

samtjo opened this issue Jul 10, 2023 · 4 comments
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation

Comments

@samtjo
Copy link

samtjo commented Jul 10, 2023

Bug report

When the Chromatic Github Action is re-run on a commit with a fully passed/accepted build and the rebuild is skipped, the buildUrl output is set to undefined. I would have expected this to be the URL of the build for that commit, would it be possible to fix that please?

This is needed for a Collibra project and we are customers of Chromatic, just mentioning as I saw the "Customer reported" label on some of the other issues.

Thanks! 😄

See an example of the terminal output for the skipped rebuild below:

Run chromaui/action@v1

Chromatic CLI v6.19.9
https://www.chromatic.com/docs/cli

Authenticating with Chromatic
    → Connecting to https://index.chromatic.com/
Authenticated with Chromatic
    → Using project token '************'
Retrieving git information
Skipping build
    → Skipping rebuild of an already fully passed/accepted build
ℹ Skipping rebuild of an already fully passed/accepted build
A build for the same commit as the last build on the branch is considered a rebuild.
If the last build is passed or accepted, the rebuild is skipped because it shouldn't change anything.
You can override this using the --force-rebuild flag.
@samtjo samtjo added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels Jul 10, 2023
@thafryer
Copy link
Member

Hi @samtjo! This is currently working as we intended. If a new build is not created, we do not set this field since their is no actual build for this CI run. What workflow is your team using with the buildUrl?

@rathpc
Copy link

rathpc commented Jul 10, 2023

Hi @samtjo! This is currently working as we intended. If a new build is not created, we do not set this field since their is no actual build for this CI run. What workflow is your team using with the buildUrl?

Wouldn't it make sense if the script is able to determine that it has already been built to simply return the url from the last built run?

That way If subsequent jobs or steps are relying on that value it will still succeed even if a rebuild wasn't required? This would be the case as well if a workflow was rerun but was built successfully the first time around.

@samtjo
Copy link
Author

samtjo commented Jul 11, 2023

Thanks for the fast response @thafryer!

What Steven said ^^^ (for context we work together on the same team). If the script is already identifying that there's a build for the same commit on the same branch, wouldn't it make sense to set the buildUrl to point at that build?

@paulelliott
Copy link
Member

Closed due to age. Please reopen if you feel this is still relevant for you.

@paulelliott paulelliott closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests

4 participants