-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromatic-diagnostics.json no longer includes storybookUrl
or webUrl
#1053
Comments
Hey @drewbrend! 👋 I just ran a build with that version of the CLI and get both of those fields in the diagnostics file. Would you be able to share a snippet of what you're seeing in your |
No errors in the logs. Here's what the output chromatic-diagnostics.json looks like. I redacted some things, let me know if you need anything further. { |
I think I see what's happening here. The Do your logs mention something like that? |
Ah okay, I think that makes sense since I was running this several times while working on configuring it in CI. In my case, we're using the deployments from a branch to add a link to the deployment on a PR so reviewers can check it out. I can construct the URL in the format of In the case of a rebuild I'd need to construct this URL instead of getting it from the value in Could a skipped run still return the links to the deployment and test results for the last run? |
Yeah that sounds reasonable to me! In an effort to prevent breaking things for other folks, I'm thinking we add a new field for |
Yes, I think that'd work for me! |
🚀 Issue was released in |
@drewbrend if you use the latest version, you should get those fields! Remember, they'll be in |
storybookUrl
andwebUrl
are very helpful for integrating into CI. We were using these, but since upgrading from v11.3.2 to v11.10.2 the output to chromatic-diagnostics.json no longer includes these.These values are still called out in the FAQ for this purpose: https://www.chromatic.com/docs/faq/get-published-storybook-url-via-ci/
Were these removed intentionally? Is there a new way we should be getting these links for the deployed storybook and results?
The text was updated successfully, but these errors were encountered: