Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xcode 9.2 compatibility #4

Open
crossle opened this issue Feb 15, 2018 · 4 comments
Open

Add Xcode 9.2 compatibility #4

crossle opened this issue Feb 15, 2018 · 4 comments

Comments

@crossle
Copy link

crossle commented Feb 15, 2018

clone the master branch, run pod install

[!] Unable to find a target named `LibSignalProtocolSwift iOS`, did find `SignalProtocol iOS`, `SignalProtocol macOS`, `SignalProtocol tvOS`, `SignalProtocol watchOS`, and `SignalProtocol Tests`.

Other compile error, UnsafeMutableRawPointer allocate and deallocate can not compile on Xcode 9.2
should use this

let ptr = UnsafeMutableRawPointer.allocate(bytes: dataLength, alignedTo: MemoryLayout<UInt8>.alignment)
        defer { ptr.deallocate(bytes: dataLength, alignedTo: MemoryLayout<UInt8>.alignment) }
@christophhagen
Copy link
Owner

christophhagen commented Mar 7, 2018

The missing targets are fixed now.

Unfortunately I can't fix the other error right now. The function deallocate(bytes:alignedTo:) is deprecated in Xcode 9.3 SDK and replaced by deallocate(). I'm not aware of a check to see which Xcode SDK is being used, or any other way to fix this.

Any help resolving this is appreciated.

@crossle
Copy link
Author

crossle commented Mar 7, 2018

BTW, libsignal-protocol-swift is it stable? i think the Swift API should like libsignal-protocol-java

@christophhagen christophhagen changed the title Workspace error Add Xcode 9.2 compatibility Mar 7, 2018
@christophhagen
Copy link
Owner

At the moment libsignal-protocol-swift only works when importing the framework directly. Cocoapods installation fails due to some problems with the module maps not being found. I'm trying to resolve the issue, probably by moving to SignalProtocolC for the C library. But this will take a few days, I'm a little busy at the moment.

@yudiz-mahavirsinh
Copy link

hey @christophhagen any update on libsignal-protocol-swift pods ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants