-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning / Version check of adaptations #123
Comments
Even though I knew what was happening, when I saw that message I thought that some users might interpret it as an error of some kind, so I agree that perhaps there is a better way to handle this. Incidentally, the new version 0.9 merely translates names in a nicer way, and has some clean-up work in its comments. |
@markusschloesser Agree, but this is a can of worms, really. I try to do the versioning for user-contributed adaptations, because you should really use git (hub) for this. And the versioning is not a straight line of versions, you might have started making changes on an earlier version, then a new version gets build in... this is essentially a fork requiring a 3-way merge instead of just being "newer". Scratching my head here. |
mmh, maybe keep it simple in the beginning and use the DATE as the indicator? |
@markusschloesser So like "this version of KnobKraft has an adaptation that is newer than your local version" as a warning? |
Yes, exactly that. Happy new year to you! 😊 |
@markusschloesser Happy new year :-) |
@christofmuc @markusschloesser @Mostelin Happy new year! :) |
@Andy2No Hihi, happy new year as well! |
When I installed and ran the new version from today, KK greeted me with "detected user adaptation, overriding inbuilt one" (or similar), which was the one for the sq80 which I downloaded from the discussion here on GH.
Now the inbuilt one would have been the newer one, that's why I deleted the user adaptation, so how about:
The text was updated successfully, but these errors were encountered: