Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning / Version check of adaptations #123

Open
markusschloesser opened this issue Dec 5, 2021 · 8 comments
Open

Versioning / Version check of adaptations #123

markusschloesser opened this issue Dec 5, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@markusschloesser
Copy link
Collaborator

When I installed and ran the new version from today, KK greeted me with "detected user adaptation, overriding inbuilt one" (or similar), which was the one for the sq80 which I downloaded from the discussion here on GH.
Now the inbuilt one would have been the newer one, that's why I deleted the user adaptation, so how about:

  1. versioning for adaptations
  2. notify user of there's a newer one inbuilt
@markusschloesser markusschloesser added the enhancement New feature or request label Dec 5, 2021
@Mostelin
Copy link

Mostelin commented Dec 6, 2021

Even though I knew what was happening, when I saw that message I thought that some users might interpret it as an error of some kind, so I agree that perhaps there is a better way to handle this.

Incidentally, the new version 0.9 merely translates names in a nicer way, and has some clean-up work in its comments.

@christofmuc
Copy link
Owner

@markusschloesser Agree, but this is a can of worms, really. I try to do the versioning for user-contributed adaptations, because you should really use git (hub) for this. And the versioning is not a straight line of versions, you might have started making changes on an earlier version, then a new version gets build in... this is essentially a fork requiring a 3-way merge instead of just being "newer". Scratching my head here.

@markusschloesser
Copy link
Collaborator Author

mmh, maybe keep it simple in the beginning and use the DATE as the indicator?

@christofmuc
Copy link
Owner

@markusschloesser So like "this version of KnobKraft has an adaptation that is newer than your local version" as a warning?

@markusschloesser
Copy link
Collaborator Author

Yes, exactly that.

Happy new year to you! 😊

@christofmuc
Copy link
Owner

@markusschloesser Happy new year :-)

@Andy2No
Copy link

Andy2No commented Jan 1, 2022

@christofmuc @markusschloesser @Mostelin Happy new year! :)

@christofmuc
Copy link
Owner

@Andy2No Hihi, happy new year as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants