Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad defaults on macos dark mode #543

Open
LeoFCardoso opened this issue Apr 11, 2020 · 7 comments
Open

Bad defaults on macos dark mode #543

LeoFCardoso opened this issue Apr 11, 2020 · 7 comments

Comments

@LeoFCardoso
Copy link

Please consider fix default color values for macos "dark mode".
Example: LeoFCardoso/pdf2pdfocr#17

@chriskiehl
Copy link
Owner

fill out the issue template, please

@LeoFCardoso
Copy link
Author

LeoFCardoso commented Apr 12, 2020

Sorry, please consider the template.

@ghost
Copy link

ghost commented Jun 24, 2020

Same with the new 1.0.4.

  • OS: Mac OS Catalina 10.15.5
  • Python Version: Python 3.7.7
  • Gooey Version: Gooey 1.0.4.0.0.0
  • Thorough description of problem: Button color defaults are wrong in dark mode, cannot read label.
    • Expected Behavior: Button text color is different from button background color.
    • Actual Behavior: Button text color is same as button background color.
  • A minimal code example -- preferably copy/pastable in the issue itself (less time figuring out how to run your code == more time debugging!)
  • Screenshot (if visual quirk): Attached.
  • Anything else you may think will be helpful: None

Screenshot 2020-06-24 at 21 55 12

from gooey import Gooey
import argparse

@Gooey
def main():
    parser = argparse.ArgumentParser()
    parser.add_argument("What… is the air-speed velocity of an unladen swallow?")
    args = parser.parse_args()

if __name__ == "__main__":
    main()``` 

@dldinternet
Copy link

dldinternet commented Feb 28, 2021

I have done some debugging and investigation on where the color defaults for wxPython widgets are that break dark mode.
I have experimented with the widgets_demo.py of GooeyExamples.
Here is what I have so far:

`

    item_default = {
        'error_color': '#ea7878',
        'label_color': '#ffffff',
        'help_color': '#363636',
        'full_width': False,
        'validator': {
            'type': 'local',
            'test': 'lambda x: True',
            'message': ''
        },
        'external_validator': {
            'cmd': '',
        }
    }
    @Gooey(dump_build_config=True,
           program_name="Widget Demo",
           advanced=True,
           auto_start=False,
           body_bg_color='#262626',
           header_bg_color='#262626',
           footer_bg_color='#262626',
           sidebar_bg_color='#262626',
           )
    def main():
        desc = "Example application to show Gooey's various widgets"
        file_help_msg = "Name of the file you want to process"
    
        my_cool_parser = GooeyParser(description=desc)
        for group in my_cool_parser.parser._action_groups:
            group.gooey_options = {'label_color': '#ffffff', 'description_color': '#363636'}
        my_cool_parser.add_argument(
            "FileChooser", help=file_help_msg, widget="FileChooser", gooey_options=item_default)
        my_cool_parser.add_argument(
            "DirectoryChooser", help=file_help_msg, widget="DirChooser", gooey_options=item_default)
        my_cool_parser.add_argument(
            "FileSaver", help=file_help_msg, widget="FileSaver", gooey_options=item_default)
        my_cool_parser.add_argument(
            "MultiFileChooser", nargs='*', help=file_help_msg, widget="MultiFileChooser", gooey_options=item_default)

`

Combining the dark mode color defaults with a call to
wx.SystemSettings.GetAppearance might be part of the solution

@umrashrf
Copy link

umrashrf commented Jun 6, 2021

It was all perfect but this tiny color thing is really a problem. I'd love to change the font color and font size of TextField myself.

I am using macOS Big Sur version 11.3.

@phirst
Copy link

phirst commented Sep 13, 2022

Any updates here?

@domino14
Copy link

please fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants