Skip to content

Commit 52554f1

Browse files
committed
px4_fmu-v4pro: cleanup SPI devs
1 parent 9183f44 commit 52554f1

File tree

4 files changed

+9
-23
lines changed

4 files changed

+9
-23
lines changed

boards/px4/fmu-v4pro/default.cmake

-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ px4_add_board(
2929
gps
3030
#heater
3131
#imu # all available imu drivers
32-
imu/bma180
33-
imu/bmi160
34-
imu/l3gd20
3532
imu/mpu6000
3633
imu/mpu9250
3734
irlock

boards/px4/fmu-v4pro/src/board_config.h

+7-12
Original file line numberDiff line numberDiff line change
@@ -162,18 +162,13 @@
162162

163163
/* Use these in place of the uint32_t enumeration to select a specific SPI device on SPI1 */
164164

165-
#define PX4_SPIDEV_GYRO PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 1)
166-
#define PX4_SPIDEV_ACCEL_MAG PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 2)
167-
#define PX4_SPIDEV_BARO PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 3)
168-
#define PX4_SPIDEV_MPU PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 4)
169-
#define PX4_SPIDEV_HMC PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 5)
170-
#define PX4_SPIDEV_ICM PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 6)
171-
#define PX4_SPIDEV_LIS PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 7)
172-
#define PX4_SPIDEV_BMI PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 8)
173-
#define PX4_SPIDEV_BMA PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 9)
174-
#define PX4_SPIDEV_EEPROM PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 12)
175-
#define PX4_SPIDEV_ICM_20608 PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 13)
176-
#define PX4_SPIDEV_ICM_20602 PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 14)
165+
#define PX4_SPIDEV_BARO PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 1)
166+
#define PX4_SPIDEV_MPU PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 2)
167+
#define PX4_SPIDEV_HMC PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 3)
168+
#define PX4_SPIDEV_LIS PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 4)
169+
#define PX4_SPIDEV_EEPROM PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 5)
170+
#define PX4_SPIDEV_ICM_20608 PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 6)
171+
#define PX4_SPIDEV_ICM_20602 PX4_MK_SPI_SEL(PX4_SPI_BUS_SENSORS, 7)
177172

178173
#define PX4_SPIDEV_EXT0 PX4_MK_SPI_SEL(PX4_SPI_BUS_EXT0, 1)
179174
#define PX4_SPIDEV_EXT1 PX4_MK_SPI_SEL(PX4_SPI_BUS_EXT1, 1)

boards/px4/fmu-v4pro/src/init.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ __EXPORT int board_app_initialize(uintptr_t arg)
332332
SPI_SETFREQUENCY(spi1, 10000000);
333333
SPI_SETBITS(spi1, 8);
334334
SPI_SETMODE(spi1, SPIDEV_MODE3);
335-
SPI_SELECT(spi1, PX4_SPIDEV_ICM, false);
335+
SPI_SELECT(spi1, PX4_SPIDEV_ICM_20602, false);
336336
SPI_SELECT(spi1, PX4_SPIDEV_BARO, false);
337337
SPI_SELECT(spi1, PX4_SPIDEV_LIS, false);
338338
SPI_SELECT(spi1, PX4_SPIDEV_MPU, false);

boards/px4/fmu-v4pro/src/spi.c

+1-7
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,9 @@ __EXPORT void stm32_spi1select(FAR struct spi_dev_s *dev, uint32_t devid, bool s
9999
/* SPI select is active low, so write !selected to select the device */
100100

101101
switch (devid) {
102-
103-
case PX4_SPIDEV_ICM:
104-
105-
/* Intended fallthrough */
106-
107102
case PX4_SPIDEV_ICM_20602:
108103

109-
/* Intended fallthrough */
110-
104+
// FALLTHROUGH
111105
case PX4_SPIDEV_ICM_20608:
112106

113107
/* Making sure the other peripherals are not selected */

0 commit comments

Comments
 (0)