Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .requestData() #679

Open
acharlop opened this issue Aug 16, 2023 · 4 comments · May be fixed by #684
Open

Add .requestData() #679

acharlop opened this issue Aug 16, 2023 · 4 comments · May be fixed by #684

Comments

@acharlop
Copy link

Hey thanks for the lib, so far the only thing blocking me from using it is requestData() is a requirement. What do you think the effort would be, and do you have a general idea of what needs to be done? I'm happy to take a shot at it and make a PR if it would help. 🙏

@harisrab
Copy link

Why is this not there? I'm in need of this ASAP as well. Library is such a clean implementation and this could definitely help ig.

@gitnlsn
Copy link

gitnlsn commented Sep 24, 2023

The IMediaRecorder interface could be extended from native MediaRecorder.

@paschaldev
Copy link

I desperately need this feature. Willing to work on a PR @acharlop if I can reach out to you for help / questions.

In my case, I need to get the current audio data when recording is paused (not stopped). This is possible with native MediaRecorder using timeslice => mediaRecorder.start(timeslice) and mediaRecorder.requestData().

@tscritch
Copy link

tscritch commented Apr 10, 2024

This is blocking me as well.
Would it need anything more than a passthrough function like these?
https://github.com/chrisguttandin/extendable-media-recorder/blob/master/src/factories/media-recorder-constructor.ts#L215-L217

If it's that simple I'll put that PR together tomorrow 👍🏻

@tscritch tscritch linked a pull request Apr 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants