Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fileLocation from getSingleResultLogMessage() signature #500

Open
chris48s opened this issue Aug 25, 2024 · 0 comments
Open

Remove fileLocation from getSingleResultLogMessage() signature #500

chris48s opened this issue Aug 25, 2024 · 0 comments
Labels
breaking changes that need to be made in a major release plugins

Comments

@chris48s
Copy link
Owner

This will be a BC break when you do it, but fileLocation is an unnecessary param to this function. It duplicates information that is in the result object.

You should remove this so that the signatures for the 2 output hooks are:

  • getSingleResultLogMessage(result, format)
  • getAllResultsLogMessage(results, format)
@chris48s chris48s added breaking changes that need to be made in a major release plugins labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking changes that need to be made in a major release plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chris48s