Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make github api calls in parallel #36

Open
chris48s opened this issue Feb 22, 2024 · 0 comments
Open

make github api calls in parallel #36

chris48s opened this issue Feb 22, 2024 · 0 comments

Comments

@chris48s
Copy link
Owner

chris48s commented Feb 22, 2024

In f5fcf29 I added pagination, but if we need to query more repos than the batch size, the API calls will be made in series.

I think the case where we need to actually make lots of API calls is relatively rare. Most python applications don't have hundreds and hundreds of dependencies.

That said, there is no dependency between the requests so I could switch from requests to httpx and fire all the requests off in a asyncio.gather() to improve performance in the case where we have to make multiple round-trips to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant