Skip to content

Commit 49724b0

Browse files
authored
Add LE TLS cert workaround (SNI vulnerability)
* TLS SNI has been disabled at Lets Encrypt TLS certificate issuing servers. This is what broke the LE TLS cert feature. Workaround now we use `standalone` mode which has the side effect of turning off `nginx` web server for about 10 seconds while the remote Lets Encrypt issuing servers create the TLS cert. certbot/certbot#5405
1 parent 779dd91 commit 49724b0

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

odoo_install.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# Execute the script to install Odoo:
1414
# ./odoo-install
1515
################################################################################
16-
versiondate="2018-02-01a"
16+
versiondate="2018-02-01b"
1717

1818
##fixed parameters
1919
OE_USER="odoo"
@@ -413,7 +413,11 @@ function install_nginx_with_LE_https_cert {
413413
#Certbot has an Nginx plugin, which is supported on many platforms, and automates both obtaining and installing certs.
414414
#Running this command will get a certificate for you and have Certbot edit your Nginx configuration automatically to serve it.
415415
#Please specify --domains, or --installer that will help in domain names autodiscovery.
416-
sudo certbot run -n --nginx --agree-tos --no-eff-email -m $email -d $domain
416+
## Original method deprecated Jan 2018 because TLS SNI vulnerability requires SNI verification turned off.
417+
## sudo certbot run -n --nginx --agree-tos --no-eff-email -m $email -d $domain
418+
## Temporary workaround method January 2018 until ppa maintainers add certbot 0.21 to ppa:certbot/certbot.
419+
## https://github.com/certbot/certbot/issues/5405#issuecomment-356498627
420+
sudo certbot -n --authenticator standalone --installer nginx --agree-tos --no-eff-email -m $email -d $domain --pre-hook "systemctl stop nginx" --post-hook "systemctl start nginx"
417421

418422
#Automating renewal
419423
#The Certbot packages on your system come with a cron job that will renew your certificates automatically before they expire.

0 commit comments

Comments
 (0)