Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash Report] Pressing "Next song" in the notification crashes the app if queue is empty #257

Closed
eomanis opened this issue Dec 21, 2024 · 3 comments
Labels
Bug Bugs. Crashes or something isn't working Crash

Comments

@eomanis
Copy link

eomanis commented Dec 21, 2024

Crash log

Crash Report:

App version:     1.8.5.1 (1085)
Git Commit Hash: d37a3b69c8c70fcc49693df53d9bd02dd33f775a
Package name:    player.phonograph.plus
Release favor:   modernStable
Android version: 15 (API 35)
Architecture:    arm64-v8a, armeabi-v7a, armeabi
Soc:             Tensor/bluejay (by Google) 
Device brand:    google (by Google)
Device model:    bluejay/Pixel 6a (code bluejay)
Build version:   2024121200
                 (2024121200)
Language:        en
Memory:          591/5602 
Screen:          2205x1080 (dpi 420)
Permissions:     Storage(READ WRITE)


Stacktrace:
java.lang.ArithmeticException: divide by zero
	at g6.j.jumpForward(SourceFile:27)
	at zf.g.d(SourceFile:57)
	at ag.h.run(SourceFile:95)
	at android.os.Handler.handleCallback(Handler.java:991)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.os.HandlerThread.run(HandlerThread.java:85)

Version

1.8.5.1

Steps to reproduce the bug

  1. Open the app when it has no playback queue, or possibly manually clear the queue
  2. Swipe down to show the smartphone's notifications
  3. In Phonograph Plus' persistent notification, touch the "Next song" button

Environment

GrapheneOS, Build number 2024121200

Screenshots or Screen recordings

No response

Other helpful information

Phonograph Plus 1.8.5.1 from F-Droid from 2024-11-09

@eomanis eomanis added Bug Bugs. Crashes or something isn't working Crash labels Dec 21, 2024
@chr56
Copy link
Owner

chr56 commented Dec 21, 2024

Confirmed. Theoretically, the notification should be dismissed in this situation, no matter what settings is on.

@chr56
Copy link
Owner

chr56 commented Dec 22, 2024

Temporary workaround is available since 07ef060:
PhonographPlus-Preview-Channel-07ef060a

@chr56 chr56 added the Closing The issue was done and would be closed soon label Dec 22, 2024
@chr56
Copy link
Owner

chr56 commented Jan 15, 2025

v1.9.0 has been released!
close!

@chr56 chr56 closed this as completed Jan 15, 2025
@chr56 chr56 removed the Closing The issue was done and would be closed soon label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs. Crashes or something isn't working Crash
Projects
None yet
Development

No branches or pull requests

2 participants