Skip to content

Commit 1865f7e

Browse files
author
Adam Kreiss
committed
Merge branch 'development' of https://github.com/chocolatey/cChoco into 95_upgrade_packages
2 parents 2fd6a03 + e9768a8 commit 1865f7e

File tree

5 files changed

+99
-2
lines changed

5 files changed

+99
-2
lines changed

.github/ISSUE_TEMPLATE/bug-report.md

+31
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
---
2+
name: Bug Report
3+
about: Create a report to help us improve cChoco
4+
title: ''
5+
labels: 0 - _Triaging, Bug, Up For Grabs
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior:
15+
1. Go to '...'
16+
2. Click on '....'
17+
3. Scroll down to '....'
18+
4. See error
19+
20+
**Expected behavior**
21+
A clear and concise description of what you expected to happen.
22+
23+
**Screenshots**
24+
If applicable, add screenshots to help explain your problem.
25+
26+
**Software (please complete the following information):**
27+
- OS: [e.g. Windows 10 1903 Build 12345]
28+
- PowerShell Version [e.g. 5.1.123]
29+
30+
**Additional context**
31+
Add any other context about the problem here.

.github/ISSUE_TEMPLATE/config.yml

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: cChoco Community Support
4+
url: https://gitter.im/chocolatey/cchoco/
5+
about: Please ask and answer questions here.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature / Enhancement Request
3+
about: Suggest an idea for improving cChoco.
4+
title: ''
5+
labels: 0 - _Triaging, Enhancement, Up For Grabs
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.

.github/pull_request_template.md

+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
<!--- Please ensure you have raised an issue for discussion before creating a Pull Request -->
2+
<!--- Provide a general summary of your changes in the Title above with the format `(GH-<ISSUE #>) Title` -->
3+
4+
## Description
5+
<!--- Describe your changes in detail -->
6+
7+
## Related Issue
8+
<!--- This project only accepts pull requests related to open issues -->
9+
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
10+
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
11+
<!--- Please link to the issue here: -->
12+
Fixes #
13+
14+
## Motivation and Context
15+
<!--- Why is this change required? What problem does it solve? -->
16+
17+
## How Has This Been Tested?
18+
<!--- Please describe in detail how you tested your changes. -->
19+
<!--- Include details of your testing environment, and the tests you ran to -->
20+
<!--- see how your change affects other areas of the code, etc. -->
21+
22+
## Screenshots (if appropriate):
23+
24+
## Types of changes
25+
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
26+
- [ ] Bug fix (non-breaking change which fixes an issue)
27+
- [ ] New feature (non-breaking change which adds functionality)
28+
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
29+
30+
## Checklist:
31+
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
32+
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
33+
- [ ] My code follows the code style of this project.
34+
- [ ] My change requires a change to the documentation.
35+
- [ ] I have updated the documentation accordingly.
36+
- [ ] I have read the **CONTRIBUTING** document.
37+
- [ ] I have added tests to cover my changes.
38+
- [ ] All new and existing tests passed.

DSCResources/cChocoPackageInstall/cChocoPackageInstall.psm1

+5-2
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,13 @@ function Test-TargetResource
183183
Write-Verbose -Message "Checking if $Name is installed"
184184

185185
if ($AutoUpgrade -and $isInstalled) {
186+
$testParams = @{
187+
pName = $Name
188+
}
186189
if ($Source){
187-
[string]$pSource = "-pSource `"$Source`""
190+
$testParams.pSource = $Source
188191
}
189-
$result = Test-LatestVersionInstalled -pName $Name $pSource
192+
$result = Test-LatestVersionInstalled @testParams
190193
} else {
191194
$result = $isInstalled
192195
}

0 commit comments

Comments
 (0)