Skip to content
This repository has been archived by the owner on Oct 1, 2022. It is now read-only.

(feat) Included review score onchain. #31

Merged
merged 2 commits into from
May 9, 2022

Conversation

islami00
Copy link
Contributor

  • Added review score in review struct
  • Added number of reviews and sum of score for easy average on project
  • Cleaned up genesis config to depend on extrinsics
  • Removed expect(s) of collateralise to return err instead.
  • Increase user rank point by one in reward_user
  • Reordered mutations in a way that the least likely to err are called last.
  • Added more tests to chocolate pallet

**Review rewarding logic for a more graceful way of handling rewarding

  • ToDo: Move docs on projectIO impl to trait definition.

* Added review score in review struct
* Added number of reviews and sum of score for easy average on project
* Cleaned up genesis config to depend on extrinsics
* Removed expect(s) of collateralise to return err instead.
* Increase user rank point by one in reward_user
* Reordered mutations in a way that the least likely to err are called last.
* Added more tests to chocolate pallet

**Review rewarding logic for a more graceful way of handling rewarding
* ToDo: Move docs on projectIO impl to trait definition.
@islami00 islami00 requested a review from SHA888 April 30, 2022 09:21
@islami00 islami00 added the enhancement New feature or request label Apr 30, 2022
@islami00 islami00 linked an issue Apr 30, 2022 that may be closed by this pull request
@islami00
Copy link
Contributor Author

Should be able to implement #22 now

@islami00 islami00 removed the request for review from SHA888 May 9, 2022 18:45
@islami00 islami00 merged commit 7eb31cd into chocolatenetwork:development May 9, 2022
@islami00 islami00 deleted the project-rating-prop branch May 9, 2022 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pallet testing
1 participant