Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility with lein npm #15

Open
cedrictools opened this issue Jan 7, 2015 · 1 comment
Open

incompatibility with lein npm #15

cedrictools opened this issue Jan 7, 2015 · 1 comment
Labels

Comments

@cedrictools
Copy link

Given this options in project.clj

:node-dependencies [["adm-zip" "latest"]
                          ["nedb" "latest"]]
     :npm-root "webkit"
     :bower {:directory "webkit/bower"}
     :bower-dependencies [[react "0.12.2"]
                                          [d3 "latest"] ]

Running lein bower install, will fail because bower.json is expected in project root but created inside the "webkit" folder due to the :npm-root option. ( https://github.com/RyanMcG/lein-npm/blob/master/src/leiningen/npm.clj#L13 )

There must be nicer ways to solve this, however dissoc :npm-root ( cedrictools@47491ac ) did the trick. ( 2 lein profiles also does).

@jvandyke
Copy link

@cedrictools can you create a pull request for this so it's easy to merge in?

@myguidingstar Can you take a look at this and patch it in please?

@hackeryarn hackeryarn added the bug label Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants