From 035c1b5ba11da1ab20a61fb036294ac79630bf81 Mon Sep 17 00:00:00 2001 From: Emre Karabulut <“ekarabulut@microsoft.com”> Date: Wed, 6 Nov 2024 08:50:18 -0800 Subject: [PATCH 1/2] fixed makehint comparison bug --- src/makehint/rtl/hintgen.sv | 4 ++-- src/makehint/rtl/makehint.sv | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/makehint/rtl/hintgen.sv b/src/makehint/rtl/hintgen.sv index 18c2fc0..ccda574 100644 --- a/src/makehint/rtl/hintgen.sv +++ b/src/makehint/rtl/hintgen.sv @@ -59,8 +59,8 @@ module hintgen assign h = (enable & ~zeroize) ? or2_res : 'b0; always_comb begin - r_lt_gamma2 = (r <= MLDSA_GAMMA2) ? 1'b1 : 1'b0; - r_gt_q_minus_gamma2 = (r > Q_MINUS_GAMMA2) ? 1'b1 : 1'b0; + r_lt_gamma2 = (r <= MLDSA_GAMMA2) ? 1'b1 : 1'b0; + r_gt_q_minus_gamma2 = (r >= Q_MINUS_GAMMA2) ? 1'b1 : 1'b0; r_eq_q_minus_gamma2 = (r == Q_MINUS_GAMMA2) ? 1'b1 : 1'b0; end diff --git a/src/makehint/rtl/makehint.sv b/src/makehint/rtl/makehint.sv index 8cc6120..b264baf 100644 --- a/src/makehint/rtl/makehint.sv +++ b/src/makehint/rtl/makehint.sv @@ -98,8 +98,6 @@ module makehint //Read fsm mh_read_state_e read_fsm_state_ps, read_fsm_state_ns; logic arc_MH_IDLE_MH_RD_MEM; - logic arc_MH_RD_MEM_MH_IDLE; - logic arc_MH_RD_MEM_MH_FLUSH_SBUF; logic arc_MH_RD_MEM_MH_WAIT1; logic arc_MH_WAIT2_MH_IDLE; // logic arc_MH_WAIT_MH_RD_MEM; //TODO don't need wait if we do all polys back to back? check this later @@ -108,7 +106,6 @@ module makehint //Hint sum logic [7:0] hintsum; logic busy_reg; - logic incr_reg_wr_addr; logic latch_hintsum_addr; //Busy flag From c89b30698621a9e78bed9ef0e001d583186556fc Mon Sep 17 00:00:00 2001 From: Emre Karabulut Date: Wed, 6 Nov 2024 17:14:36 +0000 Subject: [PATCH 2/2] MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/ekarabulut/hintgen_bug_fix' with updated timestamp and hash after successful run --- .github/workflow_metadata/pr_hash | 2 +- .github/workflow_metadata/pr_timestamp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflow_metadata/pr_hash b/.github/workflow_metadata/pr_hash index 9567e0b..5ce3982 100644 --- a/.github/workflow_metadata/pr_hash +++ b/.github/workflow_metadata/pr_hash @@ -1 +1 @@ -e337ff12efea3a322d167c7724e27216097bbf7a1eeb75f5e570e50de7f808733946bd836ef61e1fd9c8001889b61dd7 \ No newline at end of file +0498b952cc0e6254259daf7a40977490ef109005599f452d7c850f0399d1d571c41792c8008c4147c6cbbe088b49c43c \ No newline at end of file diff --git a/.github/workflow_metadata/pr_timestamp b/.github/workflow_metadata/pr_timestamp index 887643c..ed296b3 100644 --- a/.github/workflow_metadata/pr_timestamp +++ b/.github/workflow_metadata/pr_timestamp @@ -1 +1 @@ -1730743584 \ No newline at end of file +1730913274 \ No newline at end of file