Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify/Add phrase message and the modification failed phrase should not be removed. #75

Closed
alwayschoco opened this issue Mar 16, 2016 · 1 comment · Fixed by #149
Closed

Modify/Add phrase message and the modification failed phrase should not be removed. #75

alwayschoco opened this issue Mar 16, 2016 · 1 comment · Fixed by #149

Comments

@alwayschoco
Copy link

When I modify a existing phrase, the message shows "Add new phrase successful" rather than "Modify a phrase successful" .

I add a new phrase 耶(一ㄝ)
e

And then I modify it to 一ㄝˋ, but the message above shows "Add new phrase 耶(一ㄝˋ) successful" .
r

I think it should be some modify message like "Modify phrase 耶(一ㄝ) to 耶(一ㄝˋ) successful" because I didn't add any new phrase into phrase list.

Besides, if Add failed, the message should be "Add new phrase 耶(一ㄝ) failed" while if Modification failed, the message should be "Modify phrase 耶(一ㄝ) to 耶(一ㄝˋ) failed" instead of "Remove 1 phrase successful", and the original phrase before modification should not be removed. (in this example , the phrase 耶(一ㄝ) should exists in list)
@alwayschoco alwayschoco changed the title Modify phrase message Modify/Add phrase message and the modification failed phrase should not be removed. Mar 17, 2016
@david50407
Copy link
Member

Because we are re-using add and remove function in modify implementation, see #109 (comment) .
But you're right, it shouldn't remove the old phrase while failing add new phrase.

jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Mar 26, 2016
Fix the issue chewing#75, chewing#109
0f23673 
The phrase can be preserved when the "add" step in "modify" is failed.
@jeffreyhc jeffreyhc mentioned this issue Mar 26, 2016
Merged
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Mar 26, 2016
Repair the mechanism of modify phrase in UserphraseView
fbe5896 
The phrase can be preserved when the "add" step in "modify" is failed.

After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

Resolves: chewing#75
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Mar 27, 2016
Repair the mechanism of modify phrase in UserphraseView
9b27f95 
The phrase can be preserved when the "add" step in "modify" is failed.

After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

Resolves: chewing#75
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Mar 28, 2016
@jeffreyhc
Repair the mechanism of modify phrase in UserphraseView
fa2d810 
The phrase can be preserved when the "add" step in "modify" is failed.

After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

Resolves: chewing#75
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 1, 2016
@jeffreyhc
Repair the mechanism of modify phrase in UserphraseView
b3fde39 
The phrase can be preserved when the "add" step in "modify" is failed.

After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

Resolves: chewing#75
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 4, 2016
@jeffreyhc
Repair the mechanism of modify phrase in UserphraseView
b3d4998 
The phrase can be preserved when the "add" step in "modify" is failed.

After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

Resolves: chewing#75
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 9, 2016
@jeffreyhc
Reclaim the phrase during "add" manipulation
788f626 
Close chewing#75

The phrase can be preserved when the "add" step in "modify" is failed.
After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 9, 2016
@jeffreyhc
Reclaim the phrase during "add" manipulation
1dbb4da 
Close chewing#75

The phrase can be preserved when the "add" step in "modify" is failed.
After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.

See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 9, 2016
@jeffreyhc
Reclaim the phrase during "add" manipulation
271e872 
Close chewing#75
The phrase can be preserved when the "add" step in "modify" is failed.
After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 9, 2016
@jeffreyhc
Reclaim the phrase during "add" manipulation
4f2dd98 
Close chewing#75
The phrase can be preserved when the "add" step in "modify" is failed.
After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.
See also: chewing#109
jeffreyhc pushed a commit to jeffreyhc/chewing-editor that referenced this issue Apr 10, 2016
@jeffreyhc
Reclaim the phrase during "add" manipulation
a075b6b 
Close chewing#75
The phrase can be preserved when the "add" step in "modify" is failed.
After a new phrase is added, the selection of the original phrase in
chewing-editor seems to be reset, then the remove() in UserphaseView
will lost the remove target.
So I check the modified phrase add to the database successfully or not,
If the adding is fail, then re-add the original phrase.
See also: chewing#109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Phrase can be preserved when the "add" step in "modify" is failed. jeffreyhc/chewing-editor
2 participants
@david50407 @alwayschoco