Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all endpoints to have or not final slash / #732

Closed
pieroit opened this issue Mar 2, 2024 · 1 comment
Closed

Allow all endpoints to have or not final slash / #732

pieroit opened this issue Mar 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pieroit
Copy link
Member

pieroit commented Mar 2, 2024

307 redirect bug still present and emerging when Cat is behind a proxy or other apps.

Instructions here on how to decorate endpoints to support with and without slashes, and (even better) subclass fastAPI APIRouter so the issue is handled automatically

fastapi/fastapi#2060

Check also redirect_slashes parameter, may be an even easier solution
@pieroit pieroit added the bug Something isn't working label Mar 2, 2024
@pieroit pieroit moved this to 📋 Backlog in Cat Project Kanban Apr 19, 2024
@pieroit
Copy link
Member Author

pieroit commented Apr 30, 2024

Duplicate of #764

@pieroit pieroit marked this as a duplicate of #764 Apr 30, 2024
@pieroit pieroit closed this as completed Apr 30, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Cat Project Kanban Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Cat Project Kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pieroit